From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UannG-0003YT-KH
	for qemu-devel@nongnu.org; Fri, 10 May 2013 09:55:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UannF-0001jN-6y
	for qemu-devel@nongnu.org; Fri, 10 May 2013 09:55:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UannE-0001j2-UK
	for qemu-devel@nongnu.org; Fri, 10 May 2013 09:55:29 -0400
Message-ID: <518CFC45.4000105@redhat.com>
Date: Fri, 10 May 2013 15:55:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367936238-12196-1-git-send-email-pbonzini@redhat.com>
	<1367936238-12196-21-git-send-email-pbonzini@redhat.com>
	<518CF12A.2040305@ozlabs.ru>
In-Reply-To: <518CF12A.2040305@ozlabs.ru>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 20/40] pci: use memory core for iommu
	support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, jan.kiszka@siemens.com, qemu-devel@nongnu.org, qemulist@gmail.com, Avi Kivity <avi.kivity@gmail.com>, stefanha@redhat.com, david@gibson.dropbear.id.au

Il 10/05/2013 15:07, Alexey Kardashevskiy ha scritto:
>> @@ -2234,10 +2239,12 @@ static void pci_device_class_init(ObjectClass *klass, void *data)
>>      k->props = pci_props;
>>  }
>>  
>> -void pci_setup_iommu(PCIBus *bus, PCIDMAContextFunc fn, void *opaque)
>> +void pci_setup_iommu(PCIBus *bus, PCIIOMMUFunc fn, PCIIOMMUDestructorFunc dtor,
>> +                     void *opaque)
>>  {
>> -    bus->dma_context_fn = fn;
>> -    bus->dma_context_opaque = opaque;
>> +    bus->iommu_fn = fn;

Or perhaps just use pci_default_iommu if fn == NULL.

Paolo