From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uaort-0001ez-7V for qemu-devel@nongnu.org; Fri, 10 May 2013 11:04:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uaorr-0000kO-3p for qemu-devel@nongnu.org; Fri, 10 May 2013 11:04:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59040 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uaorq-0000kA-T5 for qemu-devel@nongnu.org; Fri, 10 May 2013 11:04:19 -0400 Message-ID: <518D0C6F.6090400@suse.de> Date: Fri, 10 May 2013 17:04:15 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1368188203-3407-1-git-send-email-pbonzini@redhat.com> <874nebdm4r.fsf@codemonkey.ws> <518CF130.2030402@redhat.com> <874neazz8v.fsf@codemonkey.ws> <20130510144642.GK31148@hall.aurel32.net> In-Reply-To: <20130510144642.GK31148@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org, mst@redhat.com Am 10.05.2013 16:46, schrieb Aurelien Jarno: > We have changed a pointer access in a hot path (and more are likely to > come as far as I know) to a complex function. The correct way to fix > that is to remove the complex function. FWIW I had started to investigate whether I can tweak TCG to use CPUFooState for its offset calculations as-is but to call helpers with FooCPU to get code in a uniform shape, not constantly coding casts as first thing in helper functions. We'd need a pointer similar to CPUState::env_ptr in the back part of CPU_COMMON, make FooCPU available as ArchCPU define and tweak the helper templates to support cpu type argument in addition to env. So far just an idea. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg