From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45877)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <i.mitsyanko@gmail.com>) id 1UapQf-0002MI-T5
	for qemu-devel@nongnu.org; Fri, 10 May 2013 11:40:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <i.mitsyanko@gmail.com>) id 1UapQc-0004pH-Od
	for qemu-devel@nongnu.org; Fri, 10 May 2013 11:40:17 -0400
Message-ID: <518D14D8.9040300@gmail.com>
Date: Fri, 10 May 2013 19:40:08 +0400
From: Igor Mitsyanko <i.mitsyanko@gmail.com>
MIME-Version: 1.0
References: <1368198990-44941-1-git-send-email-i.mitsyanko@gmail.com>
	<CAFEAcA_zpWNN0uPb3pYUxGw4USX8+NFS4_+b4MO8uBdwDEDLwA@mail.gmail.com>
In-Reply-To: <CAFEAcA_zpWNN0uPb3pYUxGw4USX8+NFS4_+b4MO8uBdwDEDLwA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t
 definition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org

On 05/10/2013 07:24 PM, Peter Maydell wrote:
> On 10 May 2013 16:16, Igor Mitsyanko <i.mitsyanko@gmail.com> wrote:
>> This fixes build for mingw32
>>
>> Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
>> ---
>>   include/qemu/osdep.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
>> index 42545bc..17946a3 100644
>> --- a/include/qemu/osdep.h
>> +++ b/include/qemu/osdep.h
>> @@ -163,6 +163,8 @@ int qemu_create_pidfile(const char *filename);
>>   int qemu_get_thread_id(void);
>>
>>   #ifndef CONFIG_IOVEC
>> +#include <sys/types.h>
>> +
> This is quite a long way down to have a system #include.
>
> Can we just take the existing include of sys/types.h at
> the top of the file out of its current #ifdef __OpenBSD__
> guard ?
>
> (http://hacks.owlfolio.org/header-survey/ has a full row
> of greens for sys/types.h so this should be safe.)
>
> thanks
> -- PMM

Nice link.
Long way, yes, but there's "#include <sys/uio.h>" even further down in 
this file. But I guess taking existing sys/types.h is still better, I'll 
resend it.