From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uaq1s-0000j0-Pe for qemu-devel@nongnu.org; Fri, 10 May 2013 12:18:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uaq1q-0000RS-IC for qemu-devel@nongnu.org; Fri, 10 May 2013 12:18:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33151 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uaq1q-0000QQ-CA for qemu-devel@nongnu.org; Fri, 10 May 2013 12:18:42 -0400 Message-ID: <518D1DDF.8070301@suse.de> Date: Fri, 10 May 2013 18:18:39 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1368188203-3407-1-git-send-email-pbonzini@redhat.com> <20130510155632.GL31148@hall.aurel32.net> In-Reply-To: <20130510155632.GL31148@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org, mst@redhat.com Am 10.05.2013 17:56, schrieb Aurelien Jarno: > To improve the performance a bit more, and come back to the same kind o= f > code as before, we should move simple accessors from qom/*.c to > include/qom/*.h and mark them as inline, so that they can be removed by > the compiler. Currently, even if the function is simple it's still a > call/ret in the hot path instead of a simple pointer addition. Could you be more concrete? cpu_reset() and the ELF write functions are the only such things that comes to my mind from qom/cpu.c, and they will not be called regularly during your Perl execution. You mean something from qom/object.c? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg