From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaqNB-00088o-Vy for qemu-devel@nongnu.org; Fri, 10 May 2013 12:40:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaqNA-00088q-M9 for qemu-devel@nongnu.org; Fri, 10 May 2013 12:40:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaqNA-00088U-6B for qemu-devel@nongnu.org; Fri, 10 May 2013 12:40:44 -0400 Message-ID: <518D22F2.9010907@redhat.com> Date: Fri, 10 May 2013 18:40:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1368188203-3407-1-git-send-email-pbonzini@redhat.com> <20130510155632.GL31148@hall.aurel32.net> <518D1DDF.8070301@suse.de> In-Reply-To: <518D1DDF.8070301@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Anthony Liguori , qemu-devel@nongnu.org, Aurelien Jarno , mst@redhat.com Il 10/05/2013 18:18, Andreas F=E4rber ha scritto: > Am 10.05.2013 17:56, schrieb Aurelien Jarno: >> To improve the performance a bit more, and come back to the same kind = of >> code as before, we should move simple accessors from qom/*.c to >> include/qom/*.h and mark them as inline, so that they can be removed b= y >> the compiler. Currently, even if the function is simple it's still a >> call/ret in the hot path instead of a simple pointer addition. >=20 > Could you be more concrete? cpu_reset() and the ELF write functions are > the only such things that comes to my mind from qom/cpu.c, and they wil= l > not be called regularly during your Perl execution. You mean something > from qom/object.c? Yes, the _assert versions of the casts could be made inline. Paolo