From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UatLZ-0000EW-TE for qemu-devel@nongnu.org; Fri, 10 May 2013 15:51:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UatLW-0005V3-3U for qemu-devel@nongnu.org; Fri, 10 May 2013 15:51:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UatLV-0005Uu-SI for qemu-devel@nongnu.org; Fri, 10 May 2013 15:51:14 -0400 Message-ID: <518D5037.8040605@redhat.com> Date: Fri, 10 May 2013 21:53:27 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1368027096-12108-1-git-send-email-lersek@redhat.com> <20130510193037.GI13213@vm> In-Reply-To: <20130510193037.GI13213@vm> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org On 05/10/13 21:30, mdroth wrote: > On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: >> I should have paid more attention to portability and error path cleanup >> in the CVE-2013-2007 fix. >> >> (We continue to assume, like the rest of qemu code, that >> qemu_set_cloexec() never fails internally. This should be a reasonable >> assumption when the input fd is valid.) >> >> Laszlo Ersek (2): >> qga: distinguish binary modes in "guest_file_open_modes" map >> qga: unlink just created guest-file if fchmod() or fdopen() fails on >> it > > Thanks, applied to qga branch: > > https://github.com/mdroth/qemu/commits/qga Thanks! Can you reword the second commit to include Eric's R-b? Thanks! Laszlo