From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub0Ts-0004nS-7k for qemu-devel@nongnu.org; Fri, 10 May 2013 23:28:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ub0Tq-0006Qr-Ge for qemu-devel@nongnu.org; Fri, 10 May 2013 23:28:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub0Tq-0006Qf-8N for qemu-devel@nongnu.org; Fri, 10 May 2013 23:28:18 -0400 Message-ID: <518DBACE.5000904@redhat.com> Date: Fri, 10 May 2013 21:28:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1367966349-13242-1-git-send-email-john.baboval@citrix.com> In-Reply-To: <1367966349-13242-1-git-send-email-john.baboval@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SEFWOUJXNXFNBPCXNCKR" Subject: Re: [Qemu-devel] [PATCH v4] Add 'maxqdepth' as an option to tty character devices. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Baboval Cc: "John V. Baboval" , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SEFWOUJXNXFNBPCXNCKR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/07/2013 04:39 PM, John Baboval wrote: > From: "John V. Baboval" >=20 > This parameter will cause writes to tty backed chardevs to return > -EAGAIN if the backing tty has buffered more than the specified > number of characters. When data is sent, the TIOCOUTQ ioctl is invoked > to determine the current TTY output buffer depth. >=20 > +++ b/qapi-schema.json > @@ -3182,11 +3182,14 @@ > # > # @device: The name of the special file for the device, > # i.e. /dev/ttyS0 on Unix or COM1: on Windows > -# @type: What kind of device this is. > +# > +# @maxqdepth: #optional The maximum depth of the underlying tty > +# output queue (Unix) (Since 1.6) > # > # Since: 1.4 > ## > -{ 'type': 'ChardevHostdev', 'data': { 'device' : 'str' } } > +{ 'type': 'ChardevHostdev', 'data': { 'device' : 'str', > + '*maxqdepth' : 'int' } } > =20 Thanks; this interface change looks better (I'd still like to see someone working on introspection, but it doesn't have to be you). I'll still leave the implementation details to others more qualified for that part of the review. In particular, since you are claiming this optional attribute is Linux-only, that means we'd need introspection to know whether a given qemu build supports the field (compiled on Linux) or not (compiled on mingw), not just whether the qemu is new enough (1.6) or older (1.4). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SEFWOUJXNXFNBPCXNCKR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRjbrOAAoJEKeha0olJ0Nq1qQH/0rSOKUAFcqZXU11aa/yA+y/ D8gWsP/NAUZOji9wTYREQ/mmXhDPyDO0pqQI2cqHKiKGjlT0cr4oDTLvR0lBpAk6 TmHqcDmApqLPnd6gMEjGgv+oS8ODa5+mTPQreafWmIXJ7sGUsxeyjPboFKUEcmdT cqJCUz47rDk62VAHvwNz5u8xj9VYl3A/OGsrUBESkeWZrbLwBHJreXGGiUEHoqU0 jzLgNSnWE4it1UCP51etfD/NAg10y5R+6gPTVuvQYCTuGJafpWAh2eHX5khAbqIO hzv1wpVz6Qq5f1momrTp0XFVpjTKgh4CUNU6vIkxkaI5wRqFDhNKRE5XbaW/K2w= =34CJ -----END PGP SIGNATURE----- ------enig2SEFWOUJXNXFNBPCXNCKR--