From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub111-0001qb-4d for qemu-devel@nongnu.org; Sat, 11 May 2013 00:02:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ub10l-0007R5-8w for qemu-devel@nongnu.org; Sat, 11 May 2013 00:02:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub10k-0007Qz-V4 for qemu-devel@nongnu.org; Sat, 11 May 2013 00:02:19 -0400 Message-ID: <518DC2C6.5030500@redhat.com> Date: Fri, 10 May 2013 22:02:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1367221335-22777-1-git-send-email-stefanha@redhat.com> <1367221335-22777-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1367221335-22777-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2TRAEOWNUVRDSUBVNITNS" Subject: Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Wenchao Xia , imain@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TRAEOWNUVRDSUBVNITNS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/29/2013 01:42 AM, Stefan Hajnoczi wrote: > @block-backup >=20 > +++ b/qapi-schema.json > @@ -1715,6 +1715,37 @@ > '*speed': 'int' } } > =20 > ## > +# @block-backup > +# > +# Start a point-in-time copy of a block device to a new destination. = The > +# status of ongoing block backup operations can be checked with > +# query-block-jobs. The operation can be stopped before it has comple= ted using > +# the block-job-cancel command. Still might be worth mentioning that 'query-block-jobs' will list it as a job of type 'backup'. > +# > +# @device: the name of the device whose writes should be mirrored. > +# > +# @target: the target of the new image. If the file exists, or if it > +# is a device, the existing file/device will be used as the n= ew > +# destination. If it does not exist, a new file will be crea= ted. > +# > +# @format: #optional the format of the new destination, default is to > +# probe if @mode is 'existing', else the format of the source= > +# > +# @mode: #optional whether and how QEMU should create a new image, def= ault is > +# 'absolute-paths'. > +# > +# @speed: #optional the maximum speed, in bytes per second > +# > +# Returns: nothing on success > +# If @device is not a valid block device, DeviceNotFound > +# > +# Since 1.6 > +## > +{ 'command': 'block-backup', > + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', Hmm - wondering if we should add an enum type for supported disk formats instead of using free-form strings. The wire representation would be the same, and now's the time to do it before we add introspection (it's more than just this command impacted). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2TRAEOWNUVRDSUBVNITNS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRjcLGAAoJEKeha0olJ0Nq+uMIAJ5mLhMQ3CWnjuMEEwuu5/KN 3UtsElGrOYReVcrAhI7Spufl0UIGm5ew20G75xAXG6ujoUOM7EWbLLhzlZOWDuiy ktRDm999rc1nqSk1BSA+wL01VxF0ICpHLtqZkq+kPXoAVOdNtOWNgPeCfAk4/9nT 7oYVSDGbI5ZTgsZB/5BgNb9enAnaJfCK1ETfRQmU+cB45g+t+ywm7InBD1PhgwSJ DfyRJPM6U/r2AHq4VbPT5wwYdu6aoSdDUDs1L9VcNGx0lhQ/Ic8jp82zY3WNzSaR HLoda//0X3mGBrK22U5Bs0GA4cKzepumLZtNOG07c0xYMetsYTPmvJxlveef08E= =3Z3E -----END PGP SIGNATURE----- ------enig2TRAEOWNUVRDSUBVNITNS--