From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub5g5-0007pC-IC for qemu-devel@nongnu.org; Sat, 11 May 2013 05:01:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ub5g2-0007FE-Cp for qemu-devel@nongnu.org; Sat, 11 May 2013 05:01:17 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:54645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub5g2-0007F1-1F for qemu-devel@nongnu.org; Sat, 11 May 2013 05:01:14 -0400 Received: by mail-lb0-f180.google.com with SMTP id v1so4961922lbd.11 for ; Sat, 11 May 2013 02:01:13 -0700 (PDT) Message-ID: <518E08D6.6090702@gmail.com> Date: Sat, 11 May 2013 13:01:10 +0400 From: Igor Mitsyanko MIME-Version: 1.0 References: <1364577620-32630-1-git-send-email-sw@weilnetz.de> <518D5508.8000308@gmail.com> <518DE818.2050105@weilnetz.de> In-Reply-To: <518DE818.2050105@weilnetz.de> Content-Type: multipart/mixed; boundary="------------000201050003000300030901" Subject: Re: [Qemu-devel] [PATCH] w32: Fix build with older gcc (unresolved symbol) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , Peter Maydell , aliguori@us.ibm.com, qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------000201050003000300030901 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 11.05.2013 10:41, Stefan Weil wrote: > Am 10.05.2013 22:14, schrieb Igor Mitsyanko: >> On 29.03.2013 21:20, Stefan Weil wrote: >>> The cross i586-mingw32msvc-gcc 4.4.4 from Debian Squeeze does not >>> support >>> __sync_val_compare_and_swap by default. >>> >>> Using -march=i686 fixes that and should also result in better code. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> >>> Maybe this modification is also needed for native gcc-4.4 and older >>> on Linux i386. If yes, we can move the new script code out of the >>> MinGW conditional code. >>> >>> Newer versions of gcc obviously use -march=i686 by default and >>> don't need the patch, but it also won't do any harm for those >>> versions. >>> >>> Stefan >>> >> mingw is built with --build=mingw32 and looks like it defaults to >> -march=i386 (I have gcc version 4.7.2). >> Default build on windows is broken without this patch, it should be >> applied to 1.5 probably. >> >> Tested-by: Igor Mitsyanko >> > With latest QEMU, -march=i486 is used and there should be no problem. > If there still is a problem, we have to look for the reason. > > Could you please post the output from configure? > > Regards, > Stefan > Right, looks like my configuration has __sync_fetch_and_and but doesn't have __sync_val_compare_and_swap. That's why configure check passes but build fails: LINK arm-softmmu/qemu-system-armw.exe ../migration.o: In function `migrate_finish_set_state': g:\qemu_develop_ws\qemu_upstream/migration.c:293: undefined reference to `__sync_val_compare_and_swap_4' g:\qemu_develop_ws\qemu_upstream/migration.c:293: undefined reference to `__sync_val_compare_and_swap_4' g:\qemu_develop_ws\qemu_upstream/migration.c:293: undefined reference to `__sync_val_compare_and_swap_4' collect2.exe: error: ld returned 1 exit status make[1]: *** [qemu-system-armw.exe] Error 1 make: *** [subdir-arm-softmmu] Error 2 --------------000201050003000300030901 Content-Type: text/plain; charset=windows-1251; name="configure.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="configure.txt" JCAuL2NvbmZpZ3VyZSAtLXRhcmdldC1saXN0PWFybS1zb2Z0bW11Ckluc3RhbGwgcHJlZml4 ICAgIGM6L1Byb2dyYW0gRmlsZXMvUUVNVQpCSU9TIGRpcmVjdG9yeSAgICBjOi9Qcm9ncmFt IEZpbGVzL1FFTVUKYmluYXJ5IGRpcmVjdG9yeSAgYzovUHJvZ3JhbSBGaWxlcy9RRU1VCmxp YnJhcnkgZGlyZWN0b3J5IGM6L1Byb2dyYW0gRmlsZXMvUUVNVS9saWIKbGliZXhlYyBkaXJl Y3RvcnkgYzovUHJvZ3JhbSBGaWxlcy9RRU1VL2xpYmV4ZWMKaW5jbHVkZSBkaXJlY3Rvcnkg YzovUHJvZ3JhbSBGaWxlcy9RRU1VL2luY2x1ZGUKY29uZmlnIGRpcmVjdG9yeSAgYzovUHJv Z3JhbSBGaWxlcy9RRU1VCmxvY2FsIHN0YXRlIGRpcmVjdG9yeSAgIGM6L1Byb2dyYW0gRmls ZXMvUUVNVQpTb3VyY2UgcGF0aCAgICAgICAvZy9xZW11X2RldmVsb3Bfd3MvcWVtdV91cHN0 cmVhbQpDIGNvbXBpbGVyICAgICAgICBjYwpIb3N0IEMgY29tcGlsZXIgICBjYwpPYmplY3Rp dmUtQyBjb21waWxlciBjYwpDRkxBR1MgICAgICAgICAgICAtTzIgLURfRk9SVElGWV9TT1VS Q0U9MiAtZwpRRU1VX0NGTEFHUyAgICAgICAtbTMyIC1EX19VU0VfTUlOR1dfQU5TSV9TVERJ Tz0xIC1EV0lOMzJfTEVBTl9BTkRfTUVBTiAtRFdJTlZFUj0weDUwMSAtRF9HTlVfU09VUkNF IC1EX0ZJTEVfT0ZGU0VUX0JJVFMKPTY0IC1EX0xBUkdFRklMRV9TT1VSQ0UgLVdzdHJpY3Qt cHJvdG90eXBlcyAtV3JlZHVuZGFudC1kZWNscyAtV2FsbCAtV3VuZGVmIC1Xd3JpdGUtc3Ry aW5ncyAtV21pc3NpbmctcHJvdG90eXBlcyAtZm5vLXN0CnJpY3QtYWxpYXNpbmcgIC1XZW5k aWYtbGFiZWxzIC1XbWlzc2luZy1pbmNsdWRlLWRpcnMgLVdlbXB0eS1ib2R5IC1XbmVzdGVk LWV4dGVybnMgLVdmb3JtYXQtc2VjdXJpdHkgLVdmb3JtYXQteTJrIC1XaW5pdAotc2VsZiAt V2lnbm9yZWQtcXVhbGlmaWVycyAtV29sZC1zdHlsZS1kZWNsYXJhdGlvbiAtV29sZC1zdHls ZS1kZWZpbml0aW9uIC1XdHlwZS1saW1pdHMgLWZzdGFjay1wcm90ZWN0b3ItYWxsICAtSUM6 L21pbmcKdy9pbmNsdWRlL2xpYnBuZzE0ICAgLUlDOi9taW5ndy9pbmNsdWRlL3BpeG1hbi0x CkxERkxBR1MgICAgICAgICAgIC1XbCwtLW54Y29tcGF0IC1XbCwtLW5vLXNlaCAtV2wsLS1k eW5hbWljYmFzZSAtV2wsLS13YXJuLWNvbW1vbiAtbTMyIC1nCm1ha2UgICAgICAgICAgICAg IG1ha2UKaW5zdGFsbCAgICAgICAgICAgaW5zdGFsbApweXRob24gICAgICAgICAgICBweXRo b24Kc21iZCAgICAgICAgICAgICAgL3Vzci9zYmluL3NtYmQKaG9zdCBDUFUgICAgICAgICAg aTM4Ngpob3N0IGJpZyBlbmRpYW4gICBubwp0YXJnZXQgbGlzdCAgICAgICBhcm0tc29mdG1t dQp0Y2cgZGVidWcgZW5hYmxlZCBubwpncHJvZiBlbmFibGVkICAgICBubwpzcGFyc2UgZW5h YmxlZCAgICBubwpzdHJpcCBiaW5hcmllcyAgICB5ZXMKcHJvZmlsZXIgICAgICAgICAgbm8K c3RhdGljIGJ1aWxkICAgICAgbm8KLVdlcnJvciBlbmFibGVkICAgbm8KcGl4bWFuICAgICAg ICAgICAgc3lzdGVtClNETCBzdXBwb3J0ICAgICAgIHllcwpHVEsgc3VwcG9ydCAgICAgICBu bwpjdXJzZXMgc3VwcG9ydCAgICBubwpjdXJsIHN1cHBvcnQgICAgICB5ZXMKbWluZ3czMiBz dXBwb3J0ICAgeWVzCkF1ZGlvIGRyaXZlcnMgICAgIHdpbndhdmUKQmxvY2sgd2hpdGVsaXN0 Ck1peGVyIGVtdWxhdGlvbiAgIG5vClZpcnRGUyBzdXBwb3J0ICAgIG5vClZOQyBzdXBwb3J0 ICAgICAgIHllcwpWTkMgVExTIHN1cHBvcnQgICBubwpWTkMgU0FTTCBzdXBwb3J0ICBubwpW TkMgSlBFRyBzdXBwb3J0ICB5ZXMKVk5DIFBORyBzdXBwb3J0ICAgeWVzClZOQyBXUyBzdXBw b3J0ICAgIG5vCnhlbiBzdXBwb3J0ICAgICAgIG5vCmJybGFwaSBzdXBwb3J0ICAgIG5vCmJs dWV6ICBzdXBwb3J0ICAgIG5vCkRvY3VtZW50YXRpb24gICAgIHllcwpOUFRMIHN1cHBvcnQg ICAgICBubwpHVUVTVF9CQVNFICAgICAgICB5ZXMKUElFICAgICAgICAgICAgICAgbm8KdmRl IHN1cHBvcnQgICAgICAgbm8KTGludXggQUlPIHN1cHBvcnQgbm8KQVRUUi9YQVRUUiBzdXBw b3J0IG5vCkluc3RhbGwgYmxvYnMgICAgIHllcwpLVk0gc3VwcG9ydCAgICAgICBubwpUQ0cg aW50ZXJwcmV0ZXIgICBubwpmZHQgc3VwcG9ydCAgICAgICBubwpwcmVhZHYgc3VwcG9ydCAg ICBubwpmZGF0YXN5bmMgICAgICAgICBubwptYWR2aXNlICAgICAgICAgICBubwpwb3NpeF9t YWR2aXNlICAgICBubwpzaWdldl90aHJlYWRfaWQgICBubwp1dWlkIHN1cHBvcnQgICAgICBu bwpsaWJjYXAtbmcgc3VwcG9ydCBubwp2aG9zdC1uZXQgc3VwcG9ydCBubwp2aG9zdC1zY3Np IHN1cHBvcnQgbm8KVHJhY2UgYmFja2VuZCAgICAgbm9wClRyYWNlIG91dHB1dCBmaWxlIHRy YWNlLTxwaWQ+CnNwaWNlIHN1cHBvcnQgICAgIG5vICgvKQpyYmQgc3VwcG9ydCAgICAgICBu bwp4ZnNjdGwgc3VwcG9ydCAgICBubwpuc3MgdXNlZCAgICAgICAgICBubwpsaWJ1c2IgICAg ICAgICAgICBubwp1c2IgbmV0IHJlZGlyICAgICBubwpHTFggc3VwcG9ydCAgICAgICBubwps aWJpc2NzaSBzdXBwb3J0ICBubwpidWlsZCBndWVzdCBhZ2VudCB5ZXMKc2VjY29tcCBzdXBw b3J0ICAgbm8KY29yb3V0aW5lIGJhY2tlbmQgd2luMzIKR2x1c3RlckZTIHN1cHBvcnQgbm8K dmlydGlvLWJsay1kYXRhLXBsYW5lIG5vCmdjb3YgICAgICAgICAgICAgIGdjb3YKZ2NvdiBl bmFibGVkICAgICAgbm8KVFBNIHN1cHBvcnQgICAgICAgbm8KbGlic3NoMiBzdXBwb3J0ICAg bm8KVFBNIHBhc3N0aHJvdWdoICAgbm8= --------------000201050003000300030901--