From: "Andreas Färber" <afaerber@suse.de>
To: mdroth <mdroth@linux.vnet.ibm.com>, Laszlo Ersek <lersek@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
qemu-devel@nongnu.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
Date: Sun, 12 May 2013 18:47:05 +0200 [thread overview]
Message-ID: <518FC789.4080501@suse.de> (raw)
In-Reply-To: <20130510200926.GJ13213@vm>
Am 10.05.2013 22:09, schrieb mdroth:
> On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote:
>> On 05/10/13 21:30, mdroth wrote:
>>> On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote:
>>>> I should have paid more attention to portability and error path cleanup
>>>> in the CVE-2013-2007 fix.
>>>>
>>>> (We continue to assume, like the rest of qemu code, that
>>>> qemu_set_cloexec() never fails internally. This should be a reasonable
>>>> assumption when the input fd is valid.)
>>>>
>>>> Laszlo Ersek (2):
>>>> qga: distinguish binary modes in "guest_file_open_modes" map
>>>> qga: unlink just created guest-file if fchmod() or fdopen() fails on
>>>> it
>>>
>>> Thanks, applied to qga branch:
>>>
>>> https://github.com/mdroth/qemu/commits/qga
>>
>> Thanks!
>>
>> Can you reword the second commit to include Eric's R-b?
>> <http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg01179.html>
>
> Sure, missed that one. Should be fixed in tree now.
Shouldn't at least the unlinking be backported to stable as well?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-05-12 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 15:31 [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda Laszlo Ersek
2013-05-08 15:31 ` [Qemu-devel] [PATCH v2 1/2] qga: distinguish binary modes in "guest_file_open_modes" map Laszlo Ersek
2013-05-08 15:31 ` [Qemu-devel] [PATCH v2 2/2] qga: unlink just created guest-file if fchmod() or fdopen() fails on it Laszlo Ersek
2013-05-08 17:07 ` Eric Blake
2013-05-10 13:29 ` [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda Luiz Capitulino
2013-05-10 19:30 ` mdroth
2013-05-10 19:53 ` Laszlo Ersek
2013-05-10 20:09 ` mdroth
2013-05-12 16:47 ` Andreas Färber [this message]
2013-05-13 11:33 ` mdroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518FC789.4080501@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).