From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44500)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UbZQc-0000C8-GO
	for qemu-devel@nongnu.org; Sun, 12 May 2013 12:47:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UbZQY-0008Bl-LZ
	for qemu-devel@nongnu.org; Sun, 12 May 2013 12:47:18 -0400
Message-ID: <518FC789.4080501@suse.de>
Date: Sun, 12 May 2013 18:47:05 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1368027096-12108-1-git-send-email-lersek@redhat.com>
	<20130510193037.GI13213@vm> <518D5037.8040605@redhat.com>
	<20130510200926.GJ13213@vm>
In-Reply-To: <20130510200926.GJ13213@vm>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mdroth <mdroth@linux.vnet.ibm.com>, Laszlo Ersek <lersek@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, qemu-stable <qemu-stable@nongnu.org>

Am 10.05.2013 22:09, schrieb mdroth:
> On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote:
>> On 05/10/13 21:30, mdroth wrote:
>>> On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote:
>>>> I should have paid more attention to portability and error path clea=
nup
>>>> in the CVE-2013-2007 fix.
>>>>
>>>> (We continue to assume, like the rest of qemu code, that
>>>> qemu_set_cloexec() never fails internally. This should be a reasonab=
le
>>>> assumption when the input fd is valid.)
>>>>
>>>> Laszlo Ersek (2):
>>>>   qga: distinguish binary modes in "guest_file_open_modes" map
>>>>   qga: unlink just created guest-file if fchmod() or fdopen() fails =
on
>>>>     it
>>>
>>> Thanks, applied to qga branch:
>>>
>>> https://github.com/mdroth/qemu/commits/qga
>>
>> Thanks!
>>
>> Can you reword the second commit to include Eric's R-b?
>> <http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg01179.html=
>
>=20
> Sure, missed that one. Should be fixed in tree now.

Shouldn't at least the unlinking be backported to stable as well?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg