From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
libvir-list@redhat.com, Peter Krempa <pkrempa@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2 1/1] IDE: deprecate ide-drive
Date: Thu, 10 Oct 2019 13:22:37 +0200 [thread overview]
Message-ID: <518ae20b-049d-19ee-1e86-c48466ba0655@redhat.com> (raw)
In-Reply-To: <20191009224303.10232-2-jsnow@redhat.com>
On 10/10/19 12:43 AM, John Snow wrote:
> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
> I'd like to refactor these some day, and getting rid of the super-object
> will make that easier.
>
> Either way, we don't need this.
>
> Libvirt-checked-by: Peter Krempa <pkrempa@redhat.com>
Peter made a comment regarding Laszlo's Regression-tested-by tag:
[...] nobody else is using
this convention (there are exactly 0 instances of
"Regression-tested-by" in the project git log as far as
I can see), and so in practice people reading the commits
won't really know what you meant by it. Everybody else
on the project uses "Tested-by" to mean either of the
two cases you describe above, without distinction...
It probably applies to 'Libvirt-checked-by' too.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg632705.html
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
next prev parent reply other threads:[~2019-10-10 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 22:43 [PATCH v2 0/1] IDE: Deprecate ide-drive John Snow
2019-10-09 22:43 ` [PATCH v2 1/1] IDE: deprecate ide-drive John Snow
2019-10-10 7:44 ` Thomas Huth
2019-10-10 8:49 ` Markus Armbruster
2019-10-10 11:22 ` Philippe Mathieu-Daudé [this message]
2019-10-10 11:26 ` Peter Krempa
2019-10-10 11:42 ` Philippe Mathieu-Daudé
2019-10-10 11:54 ` Peter Krempa
2019-10-10 12:40 ` Kevin Wolf
2019-10-10 18:08 ` John Snow
2019-10-11 9:12 ` Peter Krempa
2019-10-11 20:44 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518ae20b-049d-19ee-1e86-c48466ba0655@redhat.com \
--to=philmd@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).