From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ubrmz-0004wJ-JI for qemu-devel@nongnu.org; Mon, 13 May 2013 08:23:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ubrmy-0005W0-3o for qemu-devel@nongnu.org; Mon, 13 May 2013 08:23:37 -0400 Received: from mail-gh0-f173.google.com ([209.85.160.173]:52973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ubrmx-0005Vu-UU for qemu-devel@nongnu.org; Mon, 13 May 2013 08:23:36 -0400 Received: by mail-gh0-f173.google.com with SMTP id g16so1375734ghb.32 for ; Mon, 13 May 2013 05:23:35 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5190DB42.10002@redhat.com> Date: Mon, 13 May 2013 14:23:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1368442465-14363-1-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1368442465-14363-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [0/8] RFC: VFIO and guest side IOMMUs, revisited List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, alex.williamson@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, agraf@suse.de Il 13/05/2013 12:54, David Gibson ha scritto: > Specifically the way the iommu is > determined from a callback in the PCIBus means that it won't be > assigned for devices under a PCI-PCI bridge. Right. I saw the report from Alexey, but I am a bit wary of touching it because it's not a regression. In fact there is even a FIXME for it: /* FIXME: inherit memory region from bus creator */ Perhaps we can make pci_iommu_as a Bus method, where the default implementation looks up along the chain, and the end of the recursion is in SysBus or in PCI buses that have set the callback. Paolo