qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction
Date: Mon, 13 May 2013 06:51:06 -0600	[thread overview]
Message-ID: <5190E1BA.8080005@redhat.com> (raw)
In-Reply-To: <1368434774-13950-1-git-send-email-kwolf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

On 05/13/2013 02:46 AM, Kevin Wolf wrote:
> There's no reason to restrict transactions to operations related to
> block devices, so rename the type now before schema introspection stops
> us from doing so.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockdev.c       | 22 +++++++++++-----------
>  qapi-schema.json |  8 ++++----
>  2 files changed, 15 insertions(+), 15 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

However,

>  #
>  #  List of:
> -#  @BlockdevAction: information needed for the device snapshot
> +#  @TransactionAction: information needed for the device snapshot

Is this comment now out of date?

>  #
>  # Returns: nothing on success
>  #          If @device is not a valid block device, DeviceNotFound
> @@ -1640,7 +1640,7 @@
>  # Since 1.1
>  ##
>  { 'command': 'transaction',
> -  'data': { 'actions': [ 'BlockdevAction' ] } }
> +  'data': { 'actions': [ 'TransactionAction' ] } }
>  
>  ##
>  # @blockdev-snapshot-sync
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  parent reply	other threads:[~2013-05-13 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13  8:46 [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction Kevin Wolf
2013-05-13 12:35 ` Stefan Hajnoczi
2013-05-13 12:51 ` Eric Blake [this message]
2013-05-13 14:53   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5190E1BA.8080005@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).