From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbsDh-0003wn-JW for qemu-devel@nongnu.org; Mon, 13 May 2013 08:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbsDc-0006aY-F9 for qemu-devel@nongnu.org; Mon, 13 May 2013 08:51:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbsDc-0006aK-62 for qemu-devel@nongnu.org; Mon, 13 May 2013 08:51:08 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4DCp7Vo003730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 May 2013 08:51:07 -0400 Message-ID: <5190E1BA.8080005@redhat.com> Date: Mon, 13 May 2013 06:51:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1368434774-13950-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1368434774-13950-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2UKBUPGNERBBBFRRHVDUQ" Subject: Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2UKBUPGNERBBBFRRHVDUQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2013 02:46 AM, Kevin Wolf wrote: > There's no reason to restrict transactions to operations related to > block devices, so rename the type now before schema introspection stops= > us from doing so. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 22 +++++++++++----------- > qapi-schema.json | 8 ++++---- > 2 files changed, 15 insertions(+), 15 deletions(-) Reviewed-by: Eric Blake However, > # > # List of: > -# @BlockdevAction: information needed for the device snapshot > +# @TransactionAction: information needed for the device snapshot Is this comment now out of date? > # > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > @@ -1640,7 +1640,7 @@ > # Since 1.1 > ## > { 'command': 'transaction', > - 'data': { 'actions': [ 'BlockdevAction' ] } } > + 'data': { 'actions': [ 'TransactionAction' ] } } > =20 > ## > # @blockdev-snapshot-sync >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2UKBUPGNERBBBFRRHVDUQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRkOG6AAoJEKeha0olJ0NqkCYH/jE/cm+x6Siv3rnUgQzwoZuF Fqxvhb3U+Ty/9itfXBQ1A4vnyFvCCbFJlIVMi4LK62CZUe6rdBbDup/A3Cp1vnt+ aE8i0vAFpGy9aK/s7VXYhqnGwR6AD6Z4Fu1JHBylzeKNGs2St1ZmOKltNR+vX2zK 7rRVocQaIRpru+DZpz8xuPhIx9NllxCJK1ESjEyPyvYoDiCj71odkugXmaioKz5S AU3VZPcBrfS6KBl6crvArQEy/MZbcZZr4a9LzSoqmYLeCUSneahuVDDsyZzLSBHN LSQVcUjKbmiVM5HGLLtX57xFqE+SefZGI0zQ5QmqUOLk68TZ1SfZvubLivLbYBc= =nTZk -----END PGP SIGNATURE----- ------enig2UKBUPGNERBBBFRRHVDUQ--