From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbsJB-0006Up-0l for qemu-devel@nongnu.org; Mon, 13 May 2013 08:56:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbsJ9-00005L-CW for qemu-devel@nongnu.org; Mon, 13 May 2013 08:56:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbsJ9-000059-3X for qemu-devel@nongnu.org; Mon, 13 May 2013 08:56:51 -0400 Message-ID: <5190E30E.40005@redhat.com> Date: Mon, 13 May 2013 06:56:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1367221335-22777-1-git-send-email-stefanha@redhat.com> <1367221335-22777-3-git-send-email-stefanha@redhat.com> <518DC2C6.5030500@redhat.com> <20130513082811.GB6419@dhcp-200-207.str.redhat.com> In-Reply-To: <20130513082811.GB6419@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EVRQBGGFAVRIEKODAGTS" Subject: Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, Wenchao Xia , imain@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com, lcapitulino@redhat.com, dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EVRQBGGFAVRIEKODAGTS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2013 02:28 AM, Kevin Wolf wrote: >>> +{ 'command': 'block-backup', >>> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', >> >> Hmm - wondering if we should add an enum type for supported disk forma= ts >> instead of using free-form strings. The wire representation would be >> the same, and now's the time to do it before we add introspection (it'= s >> more than just this command impacted). >=20 > And ideally we shouldn't make it a static list that contains every > format for which qemu has some code, but only those that are actually > compiled in. (Hm, and probably not protocols?) >=20 > Luiz, any idea how to do something like this, a QAPI enum with values > that are determined at runtime? Especially with respect to the coming > schema introspection? Or maybe we make the 'enum' list ALL possible types, but then add a query-* command that returns an array of only those enum values that are supported. Introspection would see all types, but the query command would be the useful variant that is runtime-dependent. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2EVRQBGGFAVRIEKODAGTS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRkOMOAAoJEKeha0olJ0NqMzIH/RDs+dNNdT8rwMv9PFeBI77D YRx0k1LchCjgRtDIq5/IOjQ3iBAEJKwhYgm8O+bJddqzmu1T46tm57McjLSycxMh xBSTclj0ZVFCH20+H+sE4hvdJT9LWA2cx3G4OpPryEXYcJnNN1oeUbJfvbj6dF5/ 4s7ztAQl6g3FVTaAHe4jYNNL3uP2meLDqigRe7iODiss1+5qPP1eY6pQBLOdvvs8 dKIAq6GY7pTZrI3Pod/tSA80lTQSwaU7a/9Hxvd2sttzJG6kTwrp1hc1VGwVaBK9 Q4NhDS0EiNCHQAV2SqjuHVj/taRFjP7aVHUo4C53naHrCowqaR9gYH2QwYvFuYc= =6Tmh -----END PGP SIGNATURE----- ------enig2EVRQBGGFAVRIEKODAGTS--