* [Qemu-devel] tlb_flush() in qom/cpu.c
@ 2017-06-14 18:17 Thomas Huth
0 siblings, 0 replies; only message in thread
From: Thomas Huth @ 2017-06-14 18:17 UTC (permalink / raw)
To: Alex Bennée; +Cc: Richard Henderson, QEMU Developers, Paolo Bonzini
Hi Alex,
I'm currently trying to poison some more target-specific defines and
noticed something fishy:
In commit 1f5c00cfdb8114c ("move tlb_flush to cpu_common_reset") you
moved the call to tlb_flush() to qom/cpu.c and guarded it with a #ifdef
CONFIG_SOFTMMU. However, qom/cpu.c is common code (common-obj-y in the
Makefile), so CONFIG_SOFTMMU is *never* defined here, i.e. the
tlb_flush() is never called anymore! (this is also quite obvious since
you've changed the prototype of tlb_flush() in d10eb08f5d83 later
without adapting qom/cpu.c).
Not sure how to fix this in a nice way, though ... shall we move the
tlb_flush() back to the target-specific reset handlers?
Thomas
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-06-14 18:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-14 18:17 [Qemu-devel] tlb_flush() in qom/cpu.c Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).