* Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output
2013-04-02 12:03 [Qemu-devel] [Patch] v2 fix /proc/self/maps output Christophe Lyon
@ 2013-05-05 21:01 ` Christophe Lyon
2013-05-05 21:11 ` Peter Maydell
2013-05-14 5:49 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Christophe Lyon @ 2013-05-05 21:01 UTC (permalink / raw)
To: qemu-devel
Ping?
On 2 April 2013 14:03, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format (see show_map_vma() in
> fs/proc/task_mmu.c).
>
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
> ---
>
> Changes v1-v2:
> Additional space is now part of the format string.
>
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..c3c5c11 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5013,10 +5013,10 @@ static int open_self_maps(void *cpu_env, int fd)
> }
> if (h2g_valid(min) && h2g_valid(max)) {
> dprintf(fd, TARGET_ABI_FMT_lx "-" TARGET_ABI_FMT_lx
> - " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
> + " %c%c%c%c %08" PRIx64 " %02x:%02x %d %s%s\n",
> h2g(min), h2g(max), flag_r, flag_w,
> flag_x, flag_p, offset, dev_maj, dev_min, inode,
> - path[0] ? " " : "", path);
> + path[0] ? " " : "", path);
> }
> }
>
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output
2013-04-02 12:03 [Qemu-devel] [Patch] v2 fix /proc/self/maps output Christophe Lyon
2013-05-05 21:01 ` Christophe Lyon
@ 2013-05-05 21:11 ` Peter Maydell
2013-05-14 5:49 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2013-05-05 21:11 UTC (permalink / raw)
To: Christophe Lyon; +Cc: Riku Voipio, qemu-devel
On 2 April 2013 13:03, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format (see show_map_vma() in
> fs/proc/task_mmu.c).
>
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(CCing Riku and/or trivial might have helped.)
-- PMM
> ---
>
> Changes v1-v2:
> Additional space is now part of the format string.
>
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..c3c5c11 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5013,10 +5013,10 @@ static int open_self_maps(void *cpu_env, int fd)
> }
> if (h2g_valid(min) && h2g_valid(max)) {
> dprintf(fd, TARGET_ABI_FMT_lx "-" TARGET_ABI_FMT_lx
> - " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
> + " %c%c%c%c %08" PRIx64 " %02x:%02x %d %s%s\n",
> h2g(min), h2g(max), flag_r, flag_w,
> flag_x, flag_p, offset, dev_maj, dev_min, inode,
> - path[0] ? " " : "", path);
> + path[0] ? " " : "", path);
> }
> }
>
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output
2013-04-02 12:03 [Qemu-devel] [Patch] v2 fix /proc/self/maps output Christophe Lyon
2013-05-05 21:01 ` Christophe Lyon
2013-05-05 21:11 ` Peter Maydell
@ 2013-05-14 5:49 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2013-05-14 5:49 UTC (permalink / raw)
To: Christophe Lyon; +Cc: qemu-trivial, Peter Maydell, qemu-devel
02.04.2013 16:03, Christophe Lyon wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format (see show_map_vma() in
> fs/proc/task_mmu.c).
>
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
Thanks, applied to the trivial patches queue.
/mjt
> Changes v1-v2:
> Additional space is now part of the format string.
>
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..c3c5c11 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5013,10 +5013,10 @@ static int open_self_maps(void *cpu_env, int fd)
> }
> if (h2g_valid(min) && h2g_valid(max)) {
> dprintf(fd, TARGET_ABI_FMT_lx "-" TARGET_ABI_FMT_lx
> - " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
> + " %c%c%c%c %08" PRIx64 " %02x:%02x %d %s%s\n",
> h2g(min), h2g(max), flag_r, flag_w,
> flag_x, flag_p, offset, dev_maj, dev_min, inode,
> - path[0] ? " " : "", path);
> + path[0] ? " " : "", path);
> }
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread