From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1UcAXS-0005U7-KP
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:24:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1UcAXN-0001B7-Ue
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:24:50 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:13067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1UcAXN-0001AU-MT
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:24:45 -0400
Message-ID: <5191F4C2.6050401@huawei.com>
Date: Tue, 14 May 2013 10:24:34 +0200
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <5141F36E.10004@huawei.com>
	<CAFEAcA9CcAgtY2j5T9qqA8M5G_pP7jHPayo7eS2YRRWVEgwzZQ@mail.gmail.com>
	<5187A863.7080903@huawei.com> <5187AFC0.3090201@redhat.com>
	<5190E923.1030200@huawei.com> <5190EB36.8000001@huawei.com>
	<CAFEAcA96dBkBhZD=Tb87Bb301acvUwomjRkppuEgAQWNAcD24w@mail.gmail.com>
In-Reply-To: <CAFEAcA96dBkBhZD=Tb87Bb301acvUwomjRkppuEgAQWNAcD24w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] include/elf.h: add aarch64 ELF machine
	and relocs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 13.05.2013 20:34, Peter Maydell wrote:
> On 13 May 2013 14:31, Claudio Fontana <claudio.fontana@huawei.com> wrote:
>>
>> we will use the 26bit relative relocations in the aarch64 tcg target.
> 
> This patch looks OK, but can I ask you to just neaten up
> the #defines by making the column of values line up?
> (use spaces, not hardcoded tabs).
> 
>> @@ -616,6 +618,132 @@ typedef struct {
>>  /* Keep this the last entry.  */
>>  #define R_ARM_NUM              256
> 
> It's kind of obvious that we're doing aarch64 relocs from
> here on, but it would be nice to just put a comment
> here to explicitly separate the aarch64 relocs from the
> 32 bit ARM ones:
> 
> /* ARM AArch64 relocation types */
> 
>> +#define R_AARCH64_NONE          256 /* also accept R_ARM_NONE (0) as null */
>> +/* static data relocations */
>> +#define R_AARCH64_ABS64         257
>> +#define R_AARCH64_ABS32         258
> 
> thanks
> -- PMM
> 

I agree with your comments above, will change accordingly.

-- 
Claudio Fontana