From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcHOG-0000Ua-4p for qemu-devel@nongnu.org; Tue, 14 May 2013 11:43:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcHOE-0000p6-9w for qemu-devel@nongnu.org; Tue, 14 May 2013 11:43:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcHOE-0000oS-16 for qemu-devel@nongnu.org; Tue, 14 May 2013 11:43:46 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4EFhhoB030807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 May 2013 11:43:43 -0400 Message-ID: <51925BAE.9040900@redhat.com> Date: Tue, 14 May 2013 09:43:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1368532227-20248-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1368532227-20248-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2ECRGUFCDLXMXJDORJVAE" Subject: Re: [Qemu-devel] [PATCH v2] blockdev: Rename BlockdevAction -> TransactionAction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2ECRGUFCDLXMXJDORJVAE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/14/2013 05:50 AM, Kevin Wolf wrote: > There's no reason to restrict transactions to operations related to > block devices, so rename the type now before schema introspection stops= > us from doing so. >=20 > Also change the schema documentation of 'transaction' to not refer to > block devices or snapshots any more. Thanks for fixing that in the respin. If it helps: Reviewed-by: Eric Blake >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 22 +++++++++++----------- > qapi-schema.json | 21 ++++++++++----------- > 2 files changed, 21 insertions(+), 22 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2ECRGUFCDLXMXJDORJVAE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRkluuAAoJEKeha0olJ0NqQwIH/jSz9mZ9ZzM1G22FBqYEJ2md gSx/QMY1BpgK206zcrf/Wjj+Kc91W9y2scvcB1FTu9de48G/UgxunviQNU/QaZH8 JDVJXN3I2/OMJ1IkVsOK5D37ygML4Xo+UIiELOnKNeeLrMT3wCh6HF9MvgLsCv13 +WSH1I53Hzyq5S+swLF0jBDvFHel8ZGPGrt7PAcPesOjtUXzVvmJwFLvLrTFSePH b3rGk8hfJ/JBPUNeNq7gQ64SWZFNoLdHt0XZZZ9GAxNY5BGxQtTYfEO0TzCv2OqS kYiIt/3r0eKWrjDCgpMpYEvKlycHYHjPgDiu9a9gDrxzjJgCSTvojN1mzdwAC3I= =3maJ -----END PGP SIGNATURE----- ------enig2ECRGUFCDLXMXJDORJVAE--