From: Richard Henderson <rth@twiddle.net>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-trivial@nongnu.org, Anthony Green <green@moxielogic.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.
Date: Tue, 14 May 2013 09:02:32 -0700 [thread overview]
Message-ID: <51926018.9000606@twiddle.net> (raw)
In-Reply-To: <CAMo8BfJiF3YkzxhRZXsSnh7BsGMMMLzis__OhDvfEEpH_fFPCQ@mail.gmail.com>
On 05/13/2013 01:33 PM, Max Filippov wrote:
> memory access at points (1) and (2) can abort the instruction (it did so
> b/o the bug, but it may do so legitimately when you add MMU support),
> but it has modified REG(1) at those points, which will not be restored.
> It's probably worth carrying register modifications in some temporary
> until after the point (2).
... Which you'll recall that I pointed out during initial review, AG.
r~
next prev parent reply other threads:[~2013-05-14 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 20:04 [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill Anthony Green
2013-05-13 20:33 ` Max Filippov
2013-05-14 16:02 ` Richard Henderson [this message]
2013-12-15 4:10 ` [Qemu-devel] ping.. " Anthony Green
2013-12-15 18:51 ` Andreas Färber
2013-12-15 19:03 ` Peter Maydell
2013-12-15 19:26 ` Anthony Green
2013-12-16 0:07 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51926018.9000606@twiddle.net \
--to=rth@twiddle.net \
--cc=green@moxielogic.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).