From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UcHgc-0006Di-96
	for qemu-devel@nongnu.org; Tue, 14 May 2013 12:02:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UcHgZ-0007CO-H1
	for qemu-devel@nongnu.org; Tue, 14 May 2013 12:02:46 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51926018.9000606@twiddle.net>
Date: Tue, 14 May 2013 09:02:32 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1368475464-3116-1-git-send-email-green@moxielogic.com>
	<CAMo8BfJiF3YkzxhRZXsSnh7BsGMMMLzis__OhDvfEEpH_fFPCQ@mail.gmail.com>
In-Reply-To: <CAMo8BfJiF3YkzxhRZXsSnh7BsGMMMLzis__OhDvfEEpH_fFPCQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-trivial@nongnu.org, Anthony Green <green@moxielogic.com>, qemu-devel@nongnu.org

On 05/13/2013 01:33 PM, Max Filippov wrote:
> memory access at points (1) and (2) can abort the instruction (it did so
> b/o the bug, but it may do so legitimately when you add MMU support),
> but it has modified REG(1) at those points, which will not be restored.
> It's probably worth carrying register modifications in some temporary
> until after the point (2).

... Which you'll recall that I pointed out during initial review, AG.


r~