From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Brad Smith <brad@comstyle.com>
Subject: Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific
Date: Tue, 14 May 2013 21:28:25 +0200 [thread overview]
Message-ID: <51929059.5090102@redhat.com> (raw)
In-Reply-To: <519267E2.6080105@redhat.com>
On 05/14/13 18:35, Paolo Bonzini wrote:
> Il 14/05/2013 18:15, Brad Smith ha scritto:
>> On Tue, May 14, 2013 at 04:10:56PM -0000, Anthony Liguori wrote:
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>
>> The patch was not updated to take into consideration my comment from bug 1177774 so
>> what was commited is just as broken as before the patch.
>
> Just send a followup yourself. You and Blue Swirl are the only users of
> QEMU on OpenBSD as far as we know, so anything that you do not do
> yourself is just best-effort.
Not to argue with this, just a general note: most of whatever is
portable from the terminal IO interfaces belongs into <termios.h> indeed.
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html
Traditionally nonportable stuff related to pty allocation and
master-slave pairing has been "recently" standardized as well (as in,
SUSv3 / UNIX 03):
http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_openpt.html
(+grantpt, ptsname, unlockpt; they seem to date back to SUSv1 / UNIX 95)
CC'ing Eric for the obligatory POSIX sanity check... :)
Laszlo
next prev parent reply other threads:[~2013-05-14 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 12:05 [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific Paolo Bonzini
2013-05-14 16:10 ` Anthony Liguori
2013-05-14 16:15 ` Brad Smith
2013-05-14 16:28 ` Anthony Liguori
2013-05-14 16:35 ` Paolo Bonzini
2013-05-14 19:28 ` Laszlo Ersek [this message]
2013-05-14 19:59 ` Eric Blake
2013-05-14 18:30 ` Brad Smith
2013-05-14 21:06 ` Peter Maydell
2013-05-14 19:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51929059.5090102@redhat.com \
--to=lersek@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=brad@comstyle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).