From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36026)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UcKrT-0001uz-SO
	for qemu-devel@nongnu.org; Tue, 14 May 2013 15:26:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UcKrQ-0006hO-Jw
	for qemu-devel@nongnu.org; Tue, 14 May 2013 15:26:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UcKrQ-0006hI-BY
	for qemu-devel@nongnu.org; Tue, 14 May 2013 15:26:08 -0400
Message-ID: <51929059.5090102@redhat.com>
Date: Tue, 14 May 2013 21:28:25 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1368533121-30796-1-git-send-email-pbonzini@redhat.com>
	<201305141610.r4EGAvH4010042@d23av03.au.ibm.com>
	<20130514161524.GH25411@rox.home.comstyle.com>
	<519267E2.6080105@redhat.com>
In-Reply-To: <519267E2.6080105@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is
	glibc-specific
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Brad Smith <brad@comstyle.com>

On 05/14/13 18:35, Paolo Bonzini wrote:
> Il 14/05/2013 18:15, Brad Smith ha scritto:
>> On Tue, May 14, 2013 at 04:10:56PM -0000, Anthony Liguori wrote:
>>> Applied.  Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>
>> The patch was not updated to take into consideration my comment from bug 1177774 so
>> what was commited is just as broken as before the patch.
> 
> Just send a followup yourself.  You and Blue Swirl are the only users of
> QEMU on OpenBSD as far as we know, so anything that you do not do
> yourself is just best-effort.

Not to argue with this, just a general note: most of whatever is
portable from the terminal IO interfaces belongs into <termios.h> indeed.

http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html

Traditionally nonportable stuff related to pty allocation and
master-slave pairing has been "recently" standardized as well (as in,
SUSv3 / UNIX 03):

http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_openpt.html

(+grantpt, ptsname, unlockpt; they seem to date back to SUSv1 / UNIX 95)

CC'ing Eric for the obligatory POSIX sanity check... :)

Laszlo