From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcRBm-0000fz-PT for qemu-devel@nongnu.org; Tue, 14 May 2013 22:11:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcRBl-0006AN-PR for qemu-devel@nongnu.org; Tue, 14 May 2013 22:11:34 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:41090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcRBl-0006AD-3W for qemu-devel@nongnu.org; Tue, 14 May 2013 22:11:33 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 May 2013 11:58:44 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 5EB2B2CE8053 for ; Wed, 15 May 2013 12:11:25 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4F2BHir19136676 for ; Wed, 15 May 2013 12:11:18 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4F2BO37015533 for ; Wed, 15 May 2013 12:11:24 +1000 Message-ID: <5192EE9D.5030604@linux.vnet.ibm.com> Date: Wed, 15 May 2013 10:10:37 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1366968675-1451-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1366968675-1451-8-git-send-email-xiawenc@linux.vnet.ibm.com> <20130426144657.GB7648@stefanha-thinkpad.redhat.com> <20130429150541.298db151@redhat.com> <5181C9D4.4000905@linux.vnet.ibm.com> <20130502080206.21df203f@redhat.com> <51832636.1020900@linux.vnet.ibm.com> <518710E7.5060103@linux.vnet.ibm.com> <20130506092224.18dbac32@redhat.com> In-Reply-To: <20130506092224.18dbac32@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, phrdina@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com 于 2013-5-6 21:22, Luiz Capitulino 写道: > On Mon, 06 May 2013 10:09:43 +0800 > Wenchao Xia wrote: > >> 于 2013-5-3 10:51, Wenchao Xia 写道: >>> 于 2013-5-2 20:02, Luiz Capitulino 写道: >>>> On Thu, 02 May 2013 10:05:08 +0800 >>>> Wenchao Xia wrote: >>>> >>>>> 于 2013-4-30 3:05, Luiz Capitulino 写道: >>>>>> On Fri, 26 Apr 2013 16:46:57 +0200 >>>>>> Stefan Hajnoczi wrote: >>>>>> >>>>>>> On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote: >>>>>>>> @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon, const >>>>>>>> QDict *qdict) >>>>>>>> } >>>>>>>> >>>>>>>> if (total > 0) { >>>>>>>> - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, >>>>>>>> sizeof(buf), NULL)); >>>>>>>> + bdrv_snapshot_dump(NULL); >>>>>>>> + monitor_printf(mon, "\n"); >>>>>>> >>>>>>> Luiz: any issue with mixing monitor_printf(mon) and >>>>>>> monitor_vprintf(cur_mon) calls? I guess there was a reason for >>>>>>> explicitly passing mon instead of relying on cur_mon. >>>>>> >>>>>> where are they being mixed? >>>>>> >>>>> bdrv_snapshot_dump() used a global variable "cur_mon" inside, >>>>> instead >>>>> of let caller pass in a explicit montior* "mon", I guess that is the >>>>> question. >>>> >>>> I'd have to see the code to tell, but yes, what Stefan described is the >>>> best practice for the Monitor. >>>> >>> I think this would not be a problem until qemu wants more than one >>> human monitor console, and then we may require a data structure to tell >>> where to output the string: stdout, *mon, or even stderr, and >>> error_printf() also need to be changed. >>> >> Luiz, what is your idea? I'd like to respin v2 if no issues for it. > > As I said before, I'd have to see the code to tell. But answering your comment, > the code does support multiple monitors. > Hi Luiz, Sorry to ask again, do you think method above is OK now, waiting for your confirm. -- Best Regards Wenchao Xia