From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uce0N-0004j2-DK for qemu-devel@nongnu.org; Wed, 15 May 2013 11:52:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uce0I-00015g-68 for qemu-devel@nongnu.org; Wed, 15 May 2013 11:52:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uce0H-00015W-Rc for qemu-devel@nongnu.org; Wed, 15 May 2013 11:52:34 -0400 Message-ID: <5193AF37.5080505@redhat.com> Date: Wed, 15 May 2013 17:52:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1368189483-7915-1-git-send-email-pbonzini@redhat.com> <87y5bmyk0g.fsf@codemonkey.ws> <8738tonwr3.fsf@blackfin.pond.sub.org> <51939D96.8070406@redhat.com> <87zjvw46w2.fsf@blackfin.pond.sub.org> In-Reply-To: <87zjvw46w2.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: jordan.l.justen@intel.com, Anthony Liguori , lersek@redhat.com, qemu-devel@nongnu.org Il 15/05/2013 17:09, Markus Armbruster ha scritto: >>>>> @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion *rom_memory) >>>>> * TODO This device exists only so that users can switch between >>>>> * use of flash and ROM for the BIOS. The ability to switch was >>>>> * created because flash doesn't work with KVM. Once it does, we >>>>> - * should drop this device for new machine types. >>>>> + * should drop this device. >>>>> */ >>>>> sysfw_dev = (PcSysFwDevice*) qdev_create(NULL, "pc-sysfw"); >>>>> >>> >>> Why did you change the comment? >> >> Because we agreed on the way forward for the flash patches, and it will >> remove the need for (a) changes to machine types; (b) pc_sysfw in >> general. The device will be created iff a -pflash or -drive if=pflash >> option is provided. Thus in principle you could use -M pc-0.12 with >> -pflash and it will work. > > Yes, that's the way forward, and yes, that means we'll have no use for > the "pc-sysfw" dummy device on new machine types. But why can we > retroactively delete it from existing machine types? Because it would only affect TCG and people probably don't care much about backwards-compatible machine types with TCG. I'd rather remove the misfeature completely and start from scratch with a sane design, now that we have it. Paolo