From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcrLo-0008Oq-Ky for qemu-devel@nongnu.org; Thu, 16 May 2013 02:07:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcrLn-0002Kc-Lc for qemu-devel@nongnu.org; Thu, 16 May 2013 02:07:40 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:38191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcrLh-0002Gu-KE for qemu-devel@nongnu.org; Thu, 16 May 2013 02:07:39 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2013 03:04:54 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id A19C42CE8023 for ; Thu, 16 May 2013 16:07:18 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4G5rGn220185150 for ; Thu, 16 May 2013 15:53:17 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4G67GRD021095 for ; Thu, 16 May 2013 16:07:16 +1000 Message-ID: <51947784.7050706@linux.vnet.ibm.com> Date: Thu, 16 May 2013 14:07:00 +0800 From: Lei Li MIME-Version: 1.0 References: <1368681587-10206-1-git-send-email-akong@redhat.com> In-Reply-To: <1368681587-10206-1-git-send-email-akong@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On 05/16/2013 01:19 PM, Amos Kong wrote: > It's clearer to use defined macros than magic numbers. > > Signed-off-by: Amos Kong > --- > ui/input.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/ui/input.c b/ui/input.c > index 8ca1a03..92c44ca 100644 > --- a/ui/input.c > +++ b/ui/input.c > @@ -28,6 +28,7 @@ > #include "qapi/error.h" > #include "qmp-commands.h" > #include "qapi-types.h" > +#include "ui/keymaps.h" > > struct QEMUPutMouseEntry { > QEMUPutMouseEvent *qemu_put_mouse_event; > @@ -260,10 +261,10 @@ static void free_keycodes(void) > static void release_keys(void *opaque) > { > while (keycodes_size > 0) { > - if (keycodes[--keycodes_size] & 0x80) { > - kbd_put_keycode(0xe0); > + if (keycodes[--keycodes_size] & SCANCODE_GREY) { > + kbd_put_keycode(SCANCODE_EMUL0); > } > - kbd_put_keycode(keycodes[keycodes_size] | 0x80); > + kbd_put_keycode(keycodes[keycodes_size] | SCANCODE_UP); > } > > free_keycodes(); > @@ -297,10 +298,10 @@ void qmp_send_key(KeyValueList *keys, bool has_hold_time, int64_t hold_time, > return; > } > > - if (keycode & 0x80) { > - kbd_put_keycode(0xe0); > + if (keycode & SCANCODE_GREY) { > + kbd_put_keycode(SCANCODE_EMUL0); > } > - kbd_put_keycode(keycode & 0x7f); > + kbd_put_keycode(keycode & SCANCODE_KEYCODEMASK); > > keycodes = g_realloc(keycodes, sizeof(int) * (keycodes_size + 1)); > keycodes[keycodes_size++] = keycode; Looks good to me. Reviewed-by: Lei Li -- Lei