From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uczbv-0006SQ-3Z for qemu-devel@nongnu.org; Thu, 16 May 2013 10:56:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uczbp-0007JX-CJ for qemu-devel@nongnu.org; Thu, 16 May 2013 10:56:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uczbp-0007Il-3y for qemu-devel@nongnu.org; Thu, 16 May 2013 10:56:45 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GEuhEY013817 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 May 2013 10:56:44 -0400 Message-ID: <5194F3AA.8050203@redhat.com> Date: Thu, 16 May 2013 08:56:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1368702445-30733-1-git-send-email-akong@redhat.com> <1368702445-30733-2-git-send-email-akong@redhat.com> In-Reply-To: <1368702445-30733-2-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2RQEDMAUNELUOAIACHOWH" Subject: Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2RQEDMAUNELUOAIACHOWH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/16/2013 05:07 AM, Amos Kong wrote: > Introduce this new QMP event to notify management after guest changes > mac-table configuration. >=20 > Signed-off-by: Amos Kong > --- > QMP/qmp-events.txt | 14 ++++++++++++++ > hw/net/virtio-net.c | 12 ++++++++++++ > include/monitor/monitor.h | 1 + > monitor.c | 1 + > 4 files changed, 28 insertions(+) >=20 > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index 92fe5fb..24d62df 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -154,6 +154,20 @@ Data: > "path": "/machine/peripheral/virtio-net-pci-0" }, > "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > =20 > +MAC_TABLE_CHANGED > +----------------- > + > +Emitted mac-table configuration is changed by the guest. > + > +Data: > + > +- "name": net client name (json-string) > + > +{ "event": "MAC_TABLE_CHANGED", > + "data": { "name": "vnet0" }, > + "timestamp": { "seconds": 1368697518, "microseconds": 326866 }} > +} Is it worth trying to also provide details about the change as part of the event, to avoid having to do a round-trip query- command just to learn what the new values are? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2RQEDMAUNELUOAIACHOWH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRlPOqAAoJEKeha0olJ0NqrYkIAJ/05meop1kHHLqClT5t8NZz D1yWLhhq/TNbc8u0UvorFplSs2vPuS8G37KN4sVpr516QR5W3nvmqlM8BE+jgqFB KtwZ/SNvr650ftuMiq3YVaHTPgtTxtss+SSa4to4lBXIq3YQk73ZZq9Bh1WBnWUC n79SP+sG4PTs6tRyDCbDLfBxOdwMvaun21EkLzXxEknVgSgJU+Ft2SFZp5/N2KVt iAKJFR7NB7ulodV4e5NZ4GVTEbfXhMJ/AREdcIjFGVsKYbtbVUjlYK5UOBGEL+hf 7H4y+osYVeuY8rrKNZ74zQ+atAFBdPO+sTTWVJQ91p03j5Ug60dGo5LRNqMvPt8= =QY/L -----END PGP SIGNATURE----- ------enig2RQEDMAUNELUOAIACHOWH--