From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud0KX-00079V-8P for qemu-devel@nongnu.org; Thu, 16 May 2013 11:42:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud0KV-0006hj-Ux for qemu-devel@nongnu.org; Thu, 16 May 2013 11:42:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud0KV-0006hY-Lc for qemu-devel@nongnu.org; Thu, 16 May 2013 11:42:55 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GFgspi025435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 May 2013 11:42:55 -0400 Message-ID: <5194FE7D.6070904@redhat.com> Date: Thu, 16 May 2013 09:42:53 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GWOWWTAJVUQGRTKVGBSG" Subject: Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GWOWWTAJVUQGRTKVGBSG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/16/2013 09:34 AM, Pavel Hrdina wrote: > Tray statuses should be also reseted. Some guests may lock the tray s/reseted/reset/ > and after reset before any kernel is loaded the tray should be unlocked= =2E >=20 > Also if you reset the real computer the tray is closed. We should > do the same in qemu. Is that OS-independent hardware behavior, or is tray closing on boot merely a side effect observed on bare metal but caused by installed software (BIOS or OS code)? At any rate, being consistent with IDE doesn't hurt. >=20 > This fix is already commited for IDE CD. s/commited/committed/ > Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c. >=20 > Signed-off-by: Pavel Hrdina > --- > hw/scsi/scsi-disk.c | 3 +++ > 1 file changed, 3 insertions(+) assuming the maintainer can touch up the commit message, feel free to add= : Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GWOWWTAJVUQGRTKVGBSG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRlP59AAoJEKeha0olJ0NqwI0H/Av57AM+r7t8uhUVDpkkD4RN 4D+ud2t71bfomnhmhaBx8QO+qG7qzFP5+SIWRW73BEqsSwCJkbDVYXO0iAhK/0m2 2SJLOZ89Ek76/stqfWtbuCzYq5SA9Om5a6XtS2bZVph/7ClwniO4eOob0m+176yk YjH3HkRIXqjundE6CGcngjVPpN+lG75nQsIYHREN0yY8sTbwyLNUYA3TrwH87cbk eTS4Q+dHCa1R8MsSOmfjTgpe4WOBS7ygeyRTUCATo/qidn23wgDngK/M2409aMrE leBNKLjI7RtG3MsRkMNHro/30vIwBSOhHiampItKvPYQCwMF8LMYv5DyJs0xMnQ= =nAWz -----END PGP SIGNATURE----- ------enig2GWOWWTAJVUQGRTKVGBSG--