From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud0QF-0001Kh-41 for qemu-devel@nongnu.org; Thu, 16 May 2013 11:48:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud0QD-0000gc-Lx for qemu-devel@nongnu.org; Thu, 16 May 2013 11:48:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud0QD-0000gW-Eh for qemu-devel@nongnu.org; Thu, 16 May 2013 11:48:49 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GFmmdL027902 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 May 2013 11:48:48 -0400 Message-ID: <5194FFDE.1000408@redhat.com> Date: Thu, 16 May 2013 17:48:46 +0200 From: Pavel Hrdina MIME-Version: 1.0 References: <5194FE7D.6070904@redhat.com> In-Reply-To: <5194FE7D.6070904@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org On 16.5.2013 17:42, Eric Blake wrote: > On 05/16/2013 09:34 AM, Pavel Hrdina wrote: >> Tray statuses should be also reseted. Some guests may lock the tray > > s/reseted/reset/ > >> and after reset before any kernel is loaded the tray should be unlocked. >> >> Also if you reset the real computer the tray is closed. We should >> do the same in qemu. > > Is that OS-independent hardware behavior, or is tray closing on boot > merely a side effect observed on bare metal but caused by installed > software (BIOS or OS code)? At any rate, being consistent with IDE > doesn't hurt. > From what I just tested it is the OS-independent HW behavior. Tested on desktop: 1. Turn off the computer. 2. Turn on the computer and after few second open the CD-ROM tray before any OS system is loaded and holding the power button turn the computer off again. The CD-ROM tray should stay opened. 3. Turn on the computer and the CD-ROM tray is automatically closed. Next time I'll mention this test in the commit message. >> >> This fix is already commited for IDE CD. > > s/commited/committed/ > >> Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c. >> >> Signed-off-by: Pavel Hrdina >> --- >> hw/scsi/scsi-disk.c | 3 +++ >> 1 file changed, 3 insertions(+) > > assuming the maintainer can touch up the commit message, feel free to add: > > Reviewed-by: Eric Blake >