From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdFJF-0002Iw-Vz for qemu-devel@nongnu.org; Fri, 17 May 2013 03:42:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdFJA-0004Dv-KF for qemu-devel@nongnu.org; Fri, 17 May 2013 03:42:37 -0400 Message-ID: <5195DF61.3070502@suse.de> Date: Fri, 17 May 2013 09:42:25 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1368764711-13763-1-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1368764711-13763-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-ppc: Change default machine for 64-bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aliguori@us.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org, blauwirbel@gmail.com, qemu-ppc@nongnu.org, aurel@aurel32.net Am 17.05.2013 06:25, schrieb David Gibson: > Currently, for qemu-system-ppc64, the default machine type is 'mac99'. > Since the mac99 machine is not being actively maintained, and shows qui= te > a few signs of bitrot, Please be more specific than making such general claims in a commit message! As the default machine it certainly compiles, so where are you seeing bitrot? The DEC bridge cleanup that I once started kind of depends on the PCI cleanup you recently looked into. Andreas > this is not very sensible. This patch changes the > default machine to 'pseries', which is actively maintained and works we= ll > with most modern ppc64 Linux distributions as a guest. >=20 > Because the pseries machine type is optional (it is only built when lib= fdt > is available), this can result in a build with no default machine. In = that > case vl.c will print a "No machine found" message. This seems reasonab= le, > given that as mentioned, mac99 is unlikely to be a good choice. >=20 > Signed-off-by: David Gibson > --- > hw/ppc/mac_newworld.c | 3 --- > hw/ppc/spapr.c | 1 + > 2 files changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c > index ce44e95..dafe7d2 100644 > --- a/hw/ppc/mac_newworld.c > +++ b/hw/ppc/mac_newworld.c > @@ -458,9 +458,6 @@ static QEMUMachine core99_machine =3D { > .desc =3D "Mac99 based PowerMAC", > .init =3D ppc_core99_init, > .max_cpus =3D MAX_CPUS, > -#ifdef TARGET_PPC64 > - .is_default =3D 1, > -#endif > DEFAULT_MACHINE_OPTIONS, > }; > =20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 74a9306..ced1b63 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -1348,6 +1348,7 @@ static void ppc_spapr_init(QEMUMachineInitArgs *a= rgs) > static QEMUMachine spapr_machine =3D { > .name =3D "pseries", > .desc =3D "pSeries Logical Partition (PAPR compliant)", > + .is_default =3D 1, > .init =3D ppc_spapr_init, > .reset =3D ppc_spapr_reset, > .block_default_type =3D IF_SCSI, >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg