From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UdFo0-0002ck-KX
	for qemu-devel@nongnu.org; Fri, 17 May 2013 04:14:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UdFnv-0006A1-T0
	for qemu-devel@nongnu.org; Fri, 17 May 2013 04:14:24 -0400
Message-ID: <5195E435.4000709@redhat.com>
Date: Fri, 17 May 2013 10:03:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1365143012.git.hutao@cn.fujitsu.com>
	<6020fa77df1ada026222d876fdadab0fbe746f41.1365143012.git.hutao@cn.fujitsu.com>
	<5195D543.70005@de.ibm.com>
	<20130517074324.GH20302@localhost.localdomain>
In-Reply-To: <20130517074324.GH20302@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.5] vl: new runstate transition:
 RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Gleb Natapov <gleb@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Orit Wasserman <owasserm@redhat.com>, Juan Quintela <quintela@redhat.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Andrew Jones <drjones@redhat.com>, "1.3.x" <qemu-stable@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, Sasha Levin <levinsasha928@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>

Il 17/05/2013 09:43, Hu Tao ha scritto:
> On Fri, May 17, 2013 at 08:59:15AM +0200, Christian Borntraeger wrote:
>> On 05/04/13 08:36, Hu Tao wrote:
>>> The guest will be in this state when it is panicked.
>>>
>>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>>
>> This actually broken virsh dump without --memory-only:
>>
>> ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate'
>>
>>
>> (virsh dump without memory-only falls back to migrate "exec: cat > dumpfile")
>>
>> Christian
> 
> This patch should fix the problem:
> 
> From d470feefe3d320c43c1fb2eb43457a99b96cdc98 Mon Sep 17 00:00:00 2001
> From: Hu Tao <hutao@cn.fujitsu.com>
> Date: Fri, 17 May 2013 15:39:07 +0800
> Subject: [PATCH] vl: new runstate transition: RUN_STATE_GUEST_PANICKED ->
>  RUN_STATE_FINISH_MIGRATE
> 
> This fixes a problem that after guest panic happens, virsh dump without
> --memory-only fails:
> 
> ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate'
> 
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>

Adding qemu-stable, but perhaps we can get this into 1.5 as well.

Paolo

> ---
>  vl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/vl.c b/vl.c
> index be0a93c..59dc0b4 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -609,6 +609,7 @@ static const RunStateTransition runstate_transitions_def[] = {
>      { RUN_STATE_WATCHDOG, RUN_STATE_FINISH_MIGRATE },
>  
>      { RUN_STATE_GUEST_PANICKED, RUN_STATE_PAUSED },
> +    { RUN_STATE_GUEST_PANICKED, RUN_STATE_FINISH_MIGRATE },
>  
>      { RUN_STATE_MAX, RUN_STATE_MAX },
>  };
>