From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44271)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UdFu7-00051T-5L
	for qemu-devel@nongnu.org; Fri, 17 May 2013 04:20:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UdFu2-0000sB-Ed
	for qemu-devel@nongnu.org; Fri, 17 May 2013 04:20:43 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52060 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UdFu2-0000ry-8f
	for qemu-devel@nongnu.org; Fri, 17 May 2013 04:20:38 -0400
Message-ID: <5195E850.10103@suse.de>
Date: Fri, 17 May 2013 10:20:32 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1368584998-20053-1-git-send-email-qiaonuohan@cn.fujitsu.com>
	<1368584998-20053-2-git-send-email-qiaonuohan@cn.fujitsu.com>
In-Reply-To: <1368584998-20053-2-git-send-email-qiaonuohan@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/9 v2] Add API to manipulate dump_bitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, d.hatayama@jp.fujitsu.com, kumagai-atsushi@mxc.nes.nec.co.jp, zhangxh@cn.fujitsu.com, anderson@redhat.com, Jens Freimann <jfrei@linux.vnet.ibm.com>

Am 15.05.2013 04:29, schrieb Qiao Nuohan:
> Struct dump_bitmap is associated with a tmp file, and the tmp file can =
be used
> to save data of bitmap in kdump-compressed format temporarily.
> The following patch will use these functions to get the data of bitmap =
and cache
> them into tmp files.
>=20
> Signed-off-by: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
> Reviewed-by: Zhang Xiaohe <zhangxh@cn.fujitsu.com>
> ---
>  Makefile.target       |    2 +-
>  dump_bitmap.c         |  171 +++++++++++++++++++++++++++++++++++++++++=
++++++++
>  include/dump_bitmap.h |   60 +++++++++++++++++
>  3 files changed, 232 insertions(+), 1 deletions(-)
>  create mode 100644 dump_bitmap.c
>  create mode 100644 include/dump_bitmap.h
>=20
> diff --git a/Makefile.target b/Makefile.target
> index ce4391f..00d4f13 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -112,7 +112,7 @@ obj-$(CONFIG_FDT) +=3D device_tree.o
>  obj-$(CONFIG_KVM) +=3D kvm-all.o
>  obj-y +=3D memory.o savevm.o cputlb.o
>  obj-$(CONFIG_HAVE_GET_MEMORY_MAPPING) +=3D memory_mapping.o
> -obj-$(CONFIG_HAVE_CORE_DUMP) +=3D dump.o
> +obj-$(CONFIG_HAVE_CORE_DUMP) +=3D dump.o dump_bitmap.o
>  obj-$(CONFIG_NO_GET_MEMORY_MAPPING) +=3D memory_mapping-stub.o
>  obj-$(CONFIG_NO_CORE_DUMP) +=3D dump-stub.o
>  LIBS+=3D$(libs_softmmu)
[snip]

Jens and me have been working towards removing the dependency on
CONFIG_HAVE_CORE_DUMP. Would there be any issue building this code
unconditionally using obj-y +=3D dump_bitmap.o ?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg