From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UdFzl-0007ER-Im
	for qemu-devel@nongnu.org; Fri, 17 May 2013 04:26:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UdFze-0002ZJ-Eo
	for qemu-devel@nongnu.org; Fri, 17 May 2013 04:26:33 -0400
Message-ID: <5195E9AD.7040509@suse.de>
Date: Fri, 17 May 2013 10:26:21 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1368597869-30405-1-git-send-email-hutao@cn.fujitsu.com>
	<CAFEAcA-vp5bPwmAZj3a6HH71XkZJizQNSSTbFdrSOU60QWZRGw@mail.gmail.com>
In-Reply-To: <CAFEAcA-vp5bPwmAZj3a6HH71XkZJizQNSSTbFdrSOU60QWZRGw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t
 with hwaddr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Green <green@moxielogic.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Hu Tao <hutao@cn.fujitsu.com>

Anthony G.,

Am 15.05.2013 10:23, schrieb Peter Maydell:
> On 15 May 2013 07:04, Hu Tao <hutao@cn.fujitsu.com> wrote:
>> target_phys_addr_t has been already replaced by hwaddr, but this
>> one is introduced after.
>>
>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>=20
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>=20
> This doesn't cause compile errors because it's in a bit
> of code that can never get compiled (it's inside a
> CONFIG_USER_ONLY block but there is no moxie-linux-user
> target in configure).

A similar issue had come up before and I don't remember seeing a clear
answer:

Are you planning to actually implement moxie-linux-user and enable it by
default, so that we can catch any errors? Or should we rather drop any
such unused CONFIG_USER_ONLY code from target-moxie?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg