From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdIab-0000yt-C4 for qemu-devel@nongnu.org; Fri, 17 May 2013 07:12:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdIaZ-0000Vx-Uv for qemu-devel@nongnu.org; Fri, 17 May 2013 07:12:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdIaZ-0000Vp-Mg for qemu-devel@nongnu.org; Fri, 17 May 2013 07:12:43 -0400 Message-ID: <5196109A.30208@redhat.com> Date: Fri, 17 May 2013 13:12:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366731014-48790-2-git-send-email-jfrei@linux.vnet.ibm.com> <1368788285-29814-1-git-send-email-afaerber@suse.de> In-Reply-To: <1368788285-29814-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC qom-cpu] dump: Unconditionally compile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: peter.maydell@linaro.org, tumanova@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, rabin@rab.in, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, lcapitulino@redhat.com Il 17/05/2013 12:58, Andreas F=C3=A4rber ha scritto: > qmp_dump_guest_memory() calls dump_init() and returns an Error when > cpu_get_dump_info() returns an error, as done by the stub. > So there is no need to have a stub for qmp_dump_guest_memory(). >=20 > Enable the documentation of the always-present dump-guest-memory comman= d. >=20 > That way we can drop CONFIG_HAVE_CORE_DUMP. Nicer. :) Paolo > Signed-off-by: Andreas F=C3=A4rber > --- > Based on Ekaterina's last patch and my stub cleanup. > Next step will then be to clean up memory_mapping-stub.c. >=20 > Makefile.target | 2 +- > configure | 4 ---- > hmp-commands.hx | 2 -- > stubs/dump.c | 8 -------- > 4 files changed, 1 insertion(+), 15 deletions(-) >=20 > diff --git a/Makefile.target b/Makefile.target > index 84ec344..5b02200 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -111,7 +111,7 @@ obj-$(CONFIG_FDT) +=3D device_tree.o > obj-$(CONFIG_KVM) +=3D kvm-all.o > obj-y +=3D memory.o savevm.o cputlb.o > obj-$(CONFIG_HAVE_GET_MEMORY_MAPPING) +=3D memory_mapping.o > -obj-$(CONFIG_HAVE_CORE_DUMP) +=3D dump.o memory_mapping_common.o > +obj-y +=3D dump.o memory_mapping_common.o > obj-$(CONFIG_NO_GET_MEMORY_MAPPING) +=3D memory_mapping-stub.o > LIBS+=3D$(libs_softmmu) > =20 > diff --git a/configure b/configure > index 5ae7e4a..8f987e8 100755 > --- a/configure > +++ b/configure > @@ -4349,10 +4349,6 @@ if test "$target_bigendian" =3D "yes" ; then > fi > if test "$target_softmmu" =3D "yes" ; then > echo "CONFIG_SOFTMMU=3Dy" >> $config_target_mak > - case "$target_arch2" in > - i386|x86_64) > - echo "CONFIG_HAVE_CORE_DUMP=3Dy" >> $config_target_mak > - esac > fi > if test "$target_user_only" =3D "yes" ; then > echo "CONFIG_USER_ONLY=3Dy" >> $config_target_mak > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 9cea415..074dbe1 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -989,7 +989,6 @@ server will ask the spice/vnc client to automatical= ly reconnect using the > new parameters (if specified) once the vm migration finished successfu= lly. > ETEXI > =20 > -#if defined(CONFIG_HAVE_CORE_DUMP) > { > .name =3D "dump-guest-memory", > .args_type =3D "paging:-p,filename:F,begin:i?,length:i?", > @@ -1013,7 +1012,6 @@ gdb. > length: the memory size, in bytes. It's optional, and should be sp= ecified > with begin together. > ETEXI > -#endif > =20 > { > .name =3D "snapshot_blkdev", > diff --git a/stubs/dump.c b/stubs/dump.c > index b3f42cb..43c9a3f 100644 > --- a/stubs/dump.c > +++ b/stubs/dump.c > @@ -16,14 +16,6 @@ > #include "qapi/qmp/qerror.h" > #include "qmp-commands.h" > =20 > -/* we need this function in hmp.c */ > -void qmp_dump_guest_memory(bool paging, const char *file, bool has_beg= in, > - int64_t begin, bool has_length, int64_t len= gth, > - Error **errp) > -{ > - error_set(errp, QERR_UNSUPPORTED); > -} > - > int cpu_get_dump_info(ArchDumpInfo *info) > { > return -1; >=20