From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdRWN-0001d3-L5 for qemu-devel@nongnu.org; Fri, 17 May 2013 16:45:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdRWC-0005I6-NI for qemu-devel@nongnu.org; Fri, 17 May 2013 16:44:59 -0400 Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:42495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdRWC-0005Hx-G1 for qemu-devel@nongnu.org; Fri, 17 May 2013 16:44:48 -0400 Received: by mail-pb0-f43.google.com with SMTP id ma3so1948789pbc.30 for ; Fri, 17 May 2013 13:44:47 -0700 (PDT) Message-ID: <51969670.9000302@inktank.com> Date: Fri, 17 May 2013 13:43:28 -0700 From: Josh Durgin MIME-Version: 1.0 References: <1368568392-2127-1-git-send-email-mdroth@linux.vnet.ibm.com> <20130517190813.GD2441@vm> In-Reply-To: <20130517190813.GD2441@vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.4.2, freeze on Monday List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: Anthony Liguori , Doug Goldstein , qemu-devel , qemu-stable@nongnu.org On 05/17/2013 12:08 PM, mdroth wrote: > On Fri, May 17, 2013 at 10:46:15AM -0500, Doug Goldstein wrote: >> On Tue, May 14, 2013 at 4:52 PM, Michael Roth wrote: >> >>> Hi everyone, >>> >>> The following new patches are queued for QEMU stable v1.4.2: >>> >>> https://github.com/mdroth/qemu/commits/stable-1.4-staging >>> >>> The release is planned for 05-24-2013: >>> >>> http://wiki.qemu.org/Planning/1.4 >>> >>> Please CC qemu-stable@nongnu.org on any patches you think should be >>> included in the release. The cut-off date is 05-20-2013 for new patches. >>> >>> Testing/feedback is greatly appreciated. >>> >>> Thanks! >>> >>> >> Michael, >> >> I have one patch in my 1.4 stable queue. >> >> From: Paolo Bonzini >> Date: Wed, 13 Mar 2013 14:58:13 +0000 (+0100) >> Subject: qemu-iotests: add tests for rebasing zero clusters >> X-Git-Url: http://git.qemu.org/?p=qemu.git;a=commitdiff_plain;h=acbf30ec601b1f817febc4500025b7c4181312c4 >> >> qemu-iotests: add tests for rebasing zero clusters >> >> If zero clusters are erroneously treated as unallocated, "qemu-img rebase" >> will copy the backing file's contents onto the cluster. >> >> The bug existed also in image streaming, but since the root cause was in >> qcow2's is_allocated implementation it is enough to test it with qemu-img. >> >> Signed-off-by: Paolo Bonzini >> Signed-off-by: Stefan Hajnoczi >> >> --- >> >> >> It only adds a test for something that was fixed in 1.4.1 (maybe was fixed >> by the final 1.4.0 release I can't recall). > > Thanks, pushed this to staging along with what should be all outstanding > patches noted so far. Could you add the patch: commit dc7588c1eb3008bda53dde1d6b890cd299758155 Author: Josh Durgin Date: Fri Mar 29 13:03:23 2013 -0700 rbd: add an asynchronous flush The existing bdrv_co_flush_to_disk implementation uses rbd_flush(), which is sychronous and causes the main qemu thread to block until it is complete. This results in unresponsiveness and extra latency for the guest. Fix this by using an asynchronous version of flush. This was added to librbd with a special #define to indicate its presence, since it will be backported to stable versions. Thus, there is no need to check the version of librbd. Implement this as bdrv_aio_flush, since it matches other aio functions in the rbd block driver, and leave out bdrv_co_flush_to_disk when the asynchronous version is available. Reported-by: Oliver Francke Signed-off-by: Josh Durgin Signed-off-by: Stefan Hajnoczi I sent a cherry-pick of it to qemu-stable a couple days ago, although it applies to the stable-1.4 branch cleanly. It fixes a significant interactivity and performance problem when rbd is used with caching enabled. Thanks, Josh