From: Michael Tokarev <mjt@tls.msk.ru>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH for 1.5] ide/macio: fix wrong opaque with TRIM support
Date: Sun, 19 May 2013 18:49:46 +0400 [thread overview]
Message-ID: <5198E68A.7030805@msgid.tls.msk.ru> (raw)
In-Reply-To: <1368962825-553-1-git-send-email-aurelien@aurel32.net>
19.05.2013 15:27, Aurelien Jarno wrote:
> Commit 215e47b9 enabled TRIM by default, which revealed a bug in TRIM
> support for the IDE macio emulation driver, introduced in d353fb72.
>
> The call to dma_bdrv_io() is using a wrong opaque of type IDEState
> instead of DBDMA_io. This patch fixes that.
>
> Fixes LP#1179104
>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Tested-off-by: Michael Tokarev <mjt@tls.msk.ru>
I can confirm with this patch the ppc testcase works again.
Thanks!
/mjt
prev parent reply other threads:[~2013-05-19 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 11:27 [Qemu-devel] [PATCH for 1.5] ide/macio: fix wrong opaque with TRIM support Aurelien Jarno
2013-05-19 14:33 ` Paolo Bonzini
2013-05-19 14:49 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5198E68A.7030805@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=aurelien@aurel32.net \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).