From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
"Jason Wang" <jasowang@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Amos Kong" <akong@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"KONRAD Frederic" <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH v5] virtio-net: dynamic network offloads configuration
Date: Mon, 20 May 2013 12:52:57 +0200 [thread overview]
Message-ID: <519A0089.40109@redhat.com> (raw)
In-Reply-To: <20130520081814.GA8162@redhat.com>
Il 20/05/2013 10:18, Michael S. Tsirkin ha scritto:
> diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
> index beeead7..b315ac9 100644
> --- a/include/hw/virtio/virtio-net.h
> +++ b/include/hw/virtio/virtio-net.h
> @@ -31,6 +31,8 @@
> /* The feature bitmap for virtio net */
> #define VIRTIO_NET_F_CSUM 0 /* Host handles pkts w/ partial csum */
> #define VIRTIO_NET_F_GUEST_CSUM 1 /* Guest handles pkts w/ partial csum */
> +#define VIRTIO_NET_F_CTRL_GUEST_OFFLOADS 2 /* Control channel offload
> + * configuration support */
Any reason not to use 22?
Is there any hidden reason why bits 2..4 are not used in the spec?
Paolo
next prev parent reply other threads:[~2013-05-20 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 8:18 [Qemu-devel] [PATCH v5] virtio-net: dynamic network offloads configuration Michael S. Tsirkin
2013-05-20 10:52 ` Paolo Bonzini [this message]
2013-05-20 13:36 ` Michael S. Tsirkin
2013-05-20 13:39 ` Paolo Bonzini
2013-05-20 13:46 ` Michael S. Tsirkin
2013-05-20 14:24 ` Anthony Liguori
2013-05-22 22:58 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-05-20 14:39 Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519A0089.40109@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=fred.konrad@greensocs.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).