From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeNiH-0001Cu-To for qemu-devel@nongnu.org; Mon, 20 May 2013 06:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeNiD-0006qI-Qx for qemu-devel@nongnu.org; Mon, 20 May 2013 06:53:09 -0400 Received: from mail-yh0-x22f.google.com ([2607:f8b0:4002:c01::22f]:57032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeNiD-0006qD-Nu for qemu-devel@nongnu.org; Mon, 20 May 2013 06:53:05 -0400 Received: by mail-yh0-f47.google.com with SMTP id i57so1563949yha.20 for ; Mon, 20 May 2013 03:53:05 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <519A0089.40109@redhat.com> Date: Mon, 20 May 2013 12:52:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130520081814.GA8162@redhat.com> In-Reply-To: <20130520081814.GA8162@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5] virtio-net: dynamic network offloads configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , Amos Kong , =?ISO-8859-1?Q?Andreas_F=E4rber?= , KONRAD Frederic Il 20/05/2013 10:18, Michael S. Tsirkin ha scritto: > diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h > index beeead7..b315ac9 100644 > --- a/include/hw/virtio/virtio-net.h > +++ b/include/hw/virtio/virtio-net.h > @@ -31,6 +31,8 @@ > /* The feature bitmap for virtio net */ > #define VIRTIO_NET_F_CSUM 0 /* Host handles pkts w/ partial csum */ > #define VIRTIO_NET_F_GUEST_CSUM 1 /* Guest handles pkts w/ partial csum */ > +#define VIRTIO_NET_F_CTRL_GUEST_OFFLOADS 2 /* Control channel offload > + * configuration support */ Any reason not to use 22? Is there any hidden reason why bits 2..4 are not used in the spec? Paolo