From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UeQJX-0006f4-4I
	for qemu-devel@nongnu.org; Mon, 20 May 2013 09:39:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UeQJV-0003wZ-0n
	for qemu-devel@nongnu.org; Mon, 20 May 2013 09:39:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UeQJU-0003wJ-PF
	for qemu-devel@nongnu.org; Mon, 20 May 2013 09:39:44 -0400
Message-ID: <519A2795.9050608@redhat.com>
Date: Mon, 20 May 2013 15:39:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20130520081814.GA8162@redhat.com> <519A0089.40109@redhat.com>
	<20130520121256.GA9175@redhat.com>
In-Reply-To: <20130520121256.GA9175@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5] virtio-net: dynamic network offloads
	configuration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Amos Kong <akong@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, KONRAD Frederic <fred.konrad@greensocs.com>

Il 20/05/2013 15:36, Michael S. Tsirkin ha scritto:
> On Mon, May 20, 2013 at 12:52:57PM +0200, Paolo Bonzini wrote:
>> Il 20/05/2013 10:18, Michael S. Tsirkin ha scritto:
>>> diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
>>> index beeead7..b315ac9 100644
>>> --- a/include/hw/virtio/virtio-net.h
>>> +++ b/include/hw/virtio/virtio-net.h
>>> @@ -31,6 +31,8 @@
>>>  /* The feature bitmap for virtio net */
>>>  #define VIRTIO_NET_F_CSUM       0       /* Host handles pkts w/ partial csum */
>>>  #define VIRTIO_NET_F_GUEST_CSUM 1       /* Guest handles pkts w/ partial csum */
>>> +#define VIRTIO_NET_F_CTRL_GUEST_OFFLOADS 2 /* Control channel offload
>>> +                                         * configuration support */
>>
>> Any reason not to use 22?
> 
> There are several
> - 22 is already used by VIRTIO_NET_F_MQ

Oops, old copy here.

> - guest drivers (in development) and spec upstream both use 2
> 
> I don't know for sure, sorry.
> BTW please send questions on virtio spec on virtio
> mailing list, not here.

I could not find the message with the spec update, now I found it.  It
was a bit weird because the series had one patch for virtio-spec and one
for QEMU.

Paolo