From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeRaB-0000tU-0E for qemu-devel@nongnu.org; Mon, 20 May 2013 11:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeRa9-00085R-LW for qemu-devel@nongnu.org; Mon, 20 May 2013 11:01:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeRa9-00085F-Ad for qemu-devel@nongnu.org; Mon, 20 May 2013 11:01:01 -0400 Message-ID: <519A3AA8.2050301@redhat.com> Date: Mon, 20 May 2013 09:00:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369032665-18159-1-git-send-email-lilei@linux.vnet.ibm.com> <1369032665-18159-2-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1369032665-18159-2-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MGTDKNHUWFLILRPNEHVM" Subject: Re: [Qemu-devel] [PATCH 1/3] chardev: Make consistent with udp device for new qapi backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: armbru@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MGTDKNHUWFLILRPNEHVM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/20/2013 12:51 AM, Lei Li wrote: > When register and open a chardev udp, the backend name should be udp=20 > not dgram, and we do not have backend dgram in the chardev list. This > patch makes the new qapi udp backend consistent with the original > udp device. >=20 > Signed-off-by: Lei Li > --- > qapi-schema.json | 8 ++++---- > qemu-char.c | 10 +++++----- > 2 files changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 199744a..9302e7d 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3210,7 +3210,7 @@ > '*telnet' : 'bool' } } > =20 > ## > -# @ChardevDgram: > +# @ChardevUdp: This rename is okay, > @@ -3310,7 +3310,7 @@ > 'parallel': 'ChardevHostdev', > 'pipe' : 'ChardevHostdev', > 'socket' : 'ChardevSocket', > - 'dgram' : 'ChardevDgram', > + 'udp' : 'ChardevUdp', but this rename would be ABI-visible if it doesn't make the release. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MGTDKNHUWFLILRPNEHVM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRmjqoAAoJEKeha0olJ0NqplcH/ik844PVctFoPiVuO8ypsbsv hJoOm7UrpLqiyrfLTAC1o1z6+mrUQQwAUj25Z5tCLRPPsvtbvw8UORpmuvxb1/ow xWUbaKNOqlhITquhNCsW0Fd24x/TUEynnKa4F3SsDDSyhnKOfY1g3valsTvpPwGB srIAWtCcsh4a6uJork9Y5Jv81EINg+LIn6pWjJ+lRvQFDDPgHYRfgdAvBJ3jI34f cByluCcLGgEEyU0HVnrws4OzxCUSYg9NjObb3HANa0MlDqMP71io0bhs8OmaEeNC 74I3jJsK7JrsVgg9put63T1Y9J0blEUNNFOkZalF3GaZnJqVgeJkPTielrSnVlY= =BD2t -----END PGP SIGNATURE----- ------enig2MGTDKNHUWFLILRPNEHVM--