From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeRf7-0003bZ-4H for qemu-devel@nongnu.org; Mon, 20 May 2013 11:06:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeRf0-0001fy-Id for qemu-devel@nongnu.org; Mon, 20 May 2013 11:06:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeRf0-0001fh-AQ for qemu-devel@nongnu.org; Mon, 20 May 2013 11:06:02 -0400 Message-ID: <519A3BD6.7050304@redhat.com> Date: Mon, 20 May 2013 09:05:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369032665-18159-1-git-send-email-lilei@linux.vnet.ibm.com> <1369032665-18159-3-git-send-email-lilei@linux.vnet.ibm.com> <5199FE5B.9020706@redhat.com> <519A0226.8000105@redhat.com> In-Reply-To: <519A0226.8000105@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2QIAUCSFVJNETHVOQVHCB" Subject: Re: [Qemu-devel] [for 1.5? Qemu-devel] [PATCH 2/3] chardev: Make the name of ringbuf device consistent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: armbru@redhat.com, aliguori@us.ibm.com, Lei Li , qemu-devel@nongnu.org, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2QIAUCSFVJNETHVOQVHCB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/20/2013 04:59 AM, Paolo Bonzini wrote: > Il 20/05/2013 12:43, Paolo Bonzini ha scritto: >> Il 20/05/2013 08:51, Lei Li ha scritto: >>> Now we have ringbuf char device, but the backend name of it >>> is a little confusion. We actually register it by 'memory', but >>> the description in qemu-option, the name of open functions >>> and the new api backend called it 'ringbuf'. It should keep >>> consistent. This patch named it all to 'ringbuf'. >>> >>> Signed-off-by: Lei Li >>> --- >>> qapi-schema.json | 2 +- >>> qemu-char.c | 12 ++++++------ >>> 2 files changed, 7 insertions(+), 7 deletions(-) >>> >>> diff --git a/qapi-schema.json b/qapi-schema.json >>> index 9302e7d..61f6b34 100644 >>> --- a/qapi-schema.json >>> +++ b/qapi-schema.json >>> @@ -3321,7 +3321,7 @@ >>> 'spicevmc' : 'ChardevSpiceCha= nnel', >>> 'spiceport' : 'ChardevSpicePo= rt', >>> 'vc' : 'ChardevVC', >>> - 'memory' : 'ChardevRingbuf' }= } >>> + 'ringbuf': 'ChardevRingbuf' }= } This would be an ABI-visible change. > Oh, actually this is different. The only inconsistency is in the name > of the type, the enum is consistent with the -chardev option and it > cannot be renamed because it was in QEMU 1.4. >=20 > So we can change the type, but we can do that post 1.5. Careful. While the union existed in 1.4, it had fewer elements; the 'memory' element was added in commit 1da48c65, which means it has never been released yet. If you want to avoid an ABI change, then this commit must go in NOW. This also reiterates the question of how libvirt can know which members of a union are present, since we have added members to the union that were not available in 1.4 but still don't have a way to introspect which chardevs can be added. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2QIAUCSFVJNETHVOQVHCB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRmjvWAAoJEKeha0olJ0NqxAoH/i9viHEiniQJyLAeETqQjJL6 3cH9Vm/QljqdpRkDkOJjCrnKK7NEq/2NiyjGiAp2pXZL0OqTkLMMJPCrCFwMhcIV cSZbVPUSCBUbEKRSWKfRrJgTYrRTmhIFxm2JQJyfnYaZ7Y+vmmNrP5EURvspLRqd CWRgVpkNgcg0TFiIznltOaxMpbfcY7r0Jen9go5RC2c8xMGj3aW2YfqLonNHK9+7 65ulbpoqg4x8t7VDXvBYbMDdf3tgz1rL083hPaIUdLbv4lcn/ewr+oXyH9Oze5Fv ebuCVcyjQBrA4bO04uQ9cLkQ4p5Pjgz5LGn0aZbXwncK7lq9XKbtkdvVnMxp23w= =zNh6 -----END PGP SIGNATURE----- ------enig2QIAUCSFVJNETHVOQVHCB--