From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeTgn-0007kG-C0 for qemu-devel@nongnu.org; Mon, 20 May 2013 13:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeTgh-0006Gw-Ft for qemu-devel@nongnu.org; Mon, 20 May 2013 13:16:01 -0400 Message-ID: <519A522F.80305@redhat.com> Date: Mon, 20 May 2013 10:41:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2TJWOKEUWVGPCASKLSBCC" Subject: Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , patches@linaro.org, qemu-trivial@nongnu.org, John Rigby , qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TJWOKEUWVGPCASKLSBCC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/20/2013 10:21 AM, Peter Maydell wrote: > Reformat the qapi-schema TargetType enumeration so that it has just > one target architecture name per line. This allows patches for > adding new targets to just add a single line, rather than having > to reformat most of the list (resulting in a hard-to-check diff). >=20 > Signed-off-by: Peter Maydell > --- > d15a9c23 is an example of what you get otherwise. >=20 > I would much prefer it if we autogenerated this list so you didn't > need to change this file at all to add a new target, but Anthony > is against that; so this is at least an improvement. Yep, that raises (once again) the question of dynamic introspection - there's a difference between the maximum amount of information known at compile time, and the subset of enum values that are actually usable at runtime. This list is static (all known architectures), depending on what solutions we come up with for dynamic introspection, maybe that solution will also have a way for generating enum types. >=20 > qapi-schema.json | 30 ++++++++++++++++++++++++++---- > 1 file changed, 26 insertions(+), 4 deletions(-) At any rate, I see no harm in taking this patch as-is now, while we still spend time thinking about introspection. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2TJWOKEUWVGPCASKLSBCC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRmlIvAAoJEKeha0olJ0NqbEMH/iuxC37nMLKCasfp41lcztUE iJycTUNceziqiFbRIlC5KKLj7/cTpG+Gqjbhz6TwPRphB4Et8sh9rXfNN2Mlv4l3 5xAv/7ahA5h1fGlpCupoYJL0DE9F0hd17FRBVWhTworNmI7XWKFR0FAEE3MvQkgc +Z+3kjpPY0xpDol1KU2G0EdQGRURKvhlxoKcMI5lA9c3Pm/cdqCEpoz/JULphofJ +QX7Luo14dmaw+vdN3EAOnkvWwILgoZxluuJfQ6cOfiHphwaA79cm3+a+MKSbkZn NtpkZM773LREKatOQ1szo2M6o7rW8+WEj1DoSevk1afj/v18XhWWoxyH6Bo5kPY= =0EoN -----END PGP SIGNATURE----- ------enig2TJWOKEUWVGPCASKLSBCC--