From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e
Date: Mon, 20 May 2013 20:17:47 +0200 [thread overview]
Message-ID: <519A68CB.2040406@reactos.org> (raw)
In-Reply-To: <1368299031-17587-1-git-send-email-hpoussin@reactos.org>
Ping.
This should be IMO committed to stable, as it fixes a crash with
qemu-system-ppc -M prep -cpu 603e
Hervé
Hervé Poussineau a écrit :
> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E().
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> target-ppc/translate_init.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 6feb62a..248d3e0 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
> SPR_NOACCESS, SPR_NOACCESS,
> &spr_read_generic, &spr_write_generic,
> 0x00000000);
> - /* XXX : not implemented */
> - spr_register(env, SPR_IABR, "IABR",
> - SPR_NOACCESS, SPR_NOACCESS,
> - &spr_read_generic, &spr_write_generic,
> - 0x00000000);
> /* Memory management */
> gen_low_BATs(env);
> gen_6xx_7xx_soft_tlb(env, 64, 2);
next prev parent reply other threads:[~2013-05-20 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 19:03 [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e Hervé Poussineau
2013-05-20 18:17 ` Hervé Poussineau [this message]
2013-06-11 21:42 ` [Qemu-devel] [Qemu-stable] " mdroth
2013-06-15 18:19 ` Hervé Poussineau
2013-06-15 18:20 ` Hervé Poussineau
2013-06-15 21:00 ` [Qemu-devel] " Andreas Färber
2013-06-18 15:38 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519A68CB.2040406@reactos.org \
--to=hpoussin@reactos.org \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).