From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1UeUqA-0003H3-1Z
	for qemu-devel@nongnu.org; Mon, 20 May 2013 14:29:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1UeUei-00059i-Ol
	for qemu-devel@nongnu.org; Mon, 20 May 2013 14:19:26 -0400
Message-ID: <519A68CB.2040406@reactos.org>
Date: Mon, 20 May 2013 20:17:47 +0200
From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1368299031-17587-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1368299031-17587-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR
	twice for 603e
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-stable@nongnu.org

Ping.
This should be IMO committed to stable, as it fixes a crash with=20
qemu-system-ppc -M prep -cpu 603e

Herv=C3=A9

Herv=C3=A9 Poussineau a =C3=A9crit :
> IABR SPR is already registered in gen_spr_603(), called from init_proc_=
603E().
>=20
> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
> ---
>  target-ppc/translate_init.c |    5 -----
>  1 file changed, 5 deletions(-)
>=20
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 6feb62a..248d3e0 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env)
>                   SPR_NOACCESS, SPR_NOACCESS,
>                   &spr_read_generic, &spr_write_generic,
>                   0x00000000);
> -    /* XXX : not implemented */
> -    spr_register(env, SPR_IABR, "IABR",
> -                 SPR_NOACCESS, SPR_NOACCESS,
> -                 &spr_read_generic, &spr_write_generic,
> -                 0x00000000);
>      /* Memory management */
>      gen_low_BATs(env);
>      gen_6xx_7xx_soft_tlb(env, 64, 2);