From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uelpk-0001Mf-Bv for qemu-devel@nongnu.org; Tue, 21 May 2013 08:38:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uelpf-0001MN-A5 for qemu-devel@nongnu.org; Tue, 21 May 2013 08:38:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uelpf-0001Ln-2I for qemu-devel@nongnu.org; Tue, 21 May 2013 08:38:23 -0400 Message-ID: <519B6ABB.5030303@redhat.com> Date: Tue, 21 May 2013 06:38:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369132079-11377-1-git-send-email-lilei@linux.vnet.ibm.com> <1369132079-11377-2-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1369132079-11377-2-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2PJLXROLDKBJREKEKSDUE" Subject: Re: [Qemu-devel] [PATCH 1/2] chardev: Make the name of memory device consistent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PJLXROLDKBJREKEKSDUE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/21/2013 04:27 AM, Lei Li wrote: > Now we have memory char device, but the backend name of it > is a little confusion. We actually register it by 'memory', but > the description in qemu-option, the name of open functions > and the new api backend called it 'ringbuf'. It should keep > consistent. This patch named it all to 'memory'. >=20 > Signed-off-by: Lei Li > --- > qapi-schema.json | 6 +++--- > qemu-char.c | 16 ++++++++-------- > qemu-options.hx | 6 +++--- > 3 files changed, 14 insertions(+), 14 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 9302e7d..664b31f 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3286,7 +3286,7 @@ > '*rows' : 'int' } } > =20 > ## > -# @ChardevRingbuf: > +# @ChardevMemory: > # > # Configuration info for memory chardevs > # > @@ -3294,7 +3294,7 @@ > # > # Since: 1.5 > ## > -{ 'type': 'ChardevRingbuf', 'data': { '*size' : 'int' } } > +{ 'type': 'ChardevMemory', 'data': { '*size' : 'int' } } Since we don't have introspection (yet), this change is fine. > +++ b/qemu-options.hx > @@ -1779,7 +1779,7 @@ DEF("chardev", HAS_ARG, QEMU_OPTION_chardev, > "-chardev msmouse,id=3Did[,mux=3Don|off]\n" > "-chardev vc,id=3Did[[,width=3Dwidth][,height=3Dheight]][[,cols=3D= cols][,rows=3Drows]]\n" > " [,mux=3Don|off]\n" > - "-chardev ringbuf,id=3Did[,size=3Dsize]\n" > + "-chardev memory,id=3Did[,size=3Dsize]\n" This change impacts the command line. Have you tested whether 'query-command-line-options' exposes the difference? Libvirt does not (yet) expose a ringbuf/memory device. Assuming we add support in the future, we have several possibilities: 1. we have some way to detect the command line naming, and can thus support the device for both qemu 1.5 and 1.6 2. we can't detect the command line naming, so we can only use the device in 1.6 or newer even though it was technically available in 1.5 3. qemu continues to support ringbuf on the command line as a (possibly undocumented) alias forever, so that libvirt would ALWAYS use ringbuf regardless of qemu version My preference would be #1 or #3; but I could live with #2 as a last resor= t. As written, I don't know if your patch is option #1 or #2. I don't know whether query-command-line-options can expose the difference, or whether it can be enhanced to expose the difference in time for 1.0.6 (where if the enhancement is not present, we assume 1.5 behavior of the old name). If you can prove we can introspect the change in the command line (ie. prove this is option #1), then you can add: Reviewed-by: Eric Blake although I still think it might be worth considering option #3 in a respin or as a followup patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2PJLXROLDKBJREKEKSDUE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRm2q7AAoJEKeha0olJ0NqHRkH/3PrSb0rnnW+HN/TDuorFwQW DRLjod4P8pAOoSbSN6VkiAavWNGrc4XjqUZVEZpIp0EV/umbd7Y9bXusjW0rwkgT PMcDYBUf5x8FAypNoHd/Rry+2saMw6zuIsst2Bd8/FOKjRjfbqMt3mpsdcIPb81M qlhJ9ZVv12Q0YO5b9RwI1kgn433g2v/aP2EEozZ8lO+BEmVn1rN1VEFQtn4KkQw8 FbTDR5qvenWmPTkcsDmqvvQeFulJFSaoCyv+C4cImM8WY/iPgwp6WHiSFcewHh+7 wGdKQWH4E5fH1okOkHKAXiETB4CtPxJHcTBGsteoqTFEkrWWH2xoXFtQa1Du52Q= =4GHS -----END PGP SIGNATURE----- ------enig2PJLXROLDKBJREKEKSDUE--