From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uem6t-0001Ny-GW for qemu-devel@nongnu.org; Tue, 21 May 2013 08:56:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uem6r-0000N1-TU for qemu-devel@nongnu.org; Tue, 21 May 2013 08:56:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uem6r-0000Mx-Lo for qemu-devel@nongnu.org; Tue, 21 May 2013 08:56:09 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4LCu8YX000303 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 May 2013 08:56:08 -0400 Message-ID: <519B6EE7.30207@redhat.com> Date: Tue, 21 May 2013 06:56:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369140202-5848-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1369140202-5848-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2UOMNAABKJQHGFJRHVVEA" Subject: Re: [Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Lucas Meneghel Rodrigues , qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2UOMNAABKJQHGFJRHVVEA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/21/2013 06:43 AM, Stefan Hajnoczi wrote: > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > variable is set. The value of the environment variable determines the > bit pattern used to wipe memory. For more information, see > http://udrepper.livejournal.com/11429.html. >=20 > Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note we pick a rando= m > value from 1 to 255 to expose more bugs. If you need to reproduce a > crash use 'show environment' in gdb to extract the MALLOC_PERTURB_ > value from a core dump. >=20 > Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled. >=20 > Signed-off-by: Stefan Hajnoczi > --- > tests/Makefile | 5 ++++- > tests/qemu-iotests/check | 3 ++- > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/Makefile b/tests/Makefile > index a307d5a..24880c6 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -171,6 +171,7 @@ GCOV_OPTIONS =3D -n $(if $(V),-f,) > $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check= -qtest-y) > $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) > $(call quiet-command,QTEST_QEMU_BINARY=3D$*-softmmu/qemu-system-$* \ > + MALLOC_PERTURB_=3D${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \ This is a Makefile; don't you need to use $$ instead of $ (three instance= s)? $RANDOM is a bash-ism. If make is run with SHELL as /bin/sh on a platform where dash is the primary shell, it will fail: $ dash -c 'echo $(($RANDOM % 255))' dash: 1: arithmetic expression: expecting primary: " % 255" HOWEVER: you can exploit the fact that inside $(()), you don't need $ to use the value of a defined variable, and also the fact that unless set -u is in effect, an undefined variable name silently evaluates as 0: $ dash -c 'echo $((RANDOM % 255))' 0 then you could write the shell code: MALLOC_PERTURB_=3D${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} or the Makefile code: MALLOC_PERTURB_=3D$${MALLOC_PERTURB_:-$$((RANDOM % 255 + 1))} and things will at least work on /bin/sh as dash (even though there will be no randomness and you are always testing with 1 in that case). > @@ -180,7 +181,9 @@ $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): che= ck-qtest-%: $(check-qtest-y) > .PHONY: $(patsubst %, check-%, $(check-unit-y)) > $(patsubst %, check-%, $(check-unit-y)): check-%: % > $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) > - $(call quiet-command,gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $*,"GTE= STER $*") > + $(call quiet-command, \ > + MALLOC_PERTURB_=3D${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \ More missing $$, and a case where RANDOM is better than $RANDOM for dash.= > + gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $*,"GTESTER $*") > $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y); do= \ > echo Gcov report for $$f:;\ > $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index 432732c..74628ae 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -214,7 +214,8 @@ do > start=3D`_wallclock` > $timestamp && echo -n " ["`date "+%T"`"]" > [ ! -x $seq ] && chmod u+x $seq # ensure we can run it > - ./$seq >$tmp.out 2>&1 > + MALLOC_PERTURB_=3D${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \ > + ./$seq >$tmp.out 2>&1 THIS file requires /bin/bash, so using a bashism here is just fine. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2UOMNAABKJQHGFJRHVVEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRm27nAAoJEKeha0olJ0NqBYQH/3DMgoR9mfTfgmuLuiz8/94w 6MrwxZ/5Hxbo4cLZZ4H8Yh6yawiue+mRJsgnrPTu67Gx55ZvmFYFLf3upr8JlATI qn9PnKRcbCV5dVXeb3orfU8KfWdXzo0al/Q0oQaKhTm/arThM0LEF88lV248Sxsr 2Zlr0omfkFQbTxAFXD++MZZmaQfKYTJFOzMWiDP3j7QdfwR4lnhB1dRUaVMXAwn6 9syjH8TLRWIlvnFGvBGx9XjfX25MZerCkNJMSOT1KQwY5p8GOaJi+7Dc2Nd4gvH+ VP5rgD1GZd40+EBOOvYafccoQSB528o4v++vvrYnzXNQV7qsDJe6emO+zWhtZps= =vT0x -----END PGP SIGNATURE----- ------enig2UOMNAABKJQHGFJRHVVEA--