From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory bugs
Date: Tue, 21 May 2013 09:58:45 -0600 [thread overview]
Message-ID: <519B99B5.2040702@redhat.com> (raw)
In-Reply-To: <20130521151715.GA8903@stefanha-thinkpad.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On 05/21/2013 09:17 AM, Stefan Hajnoczi wrote:
>>> + MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \
>>
>> This is a Makefile; don't you need to use $$ instead of $ (three instances)?
>>
>
> Silly me. I did test it but it silently "worked".
Yep, quite a fluke. GNU Make expands it to:
MALLOC_PERTURB_=
which meant you were setting it to the empty variable; and thus had no
randomness but no syntax error to tell you your mistake.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
prev parent reply other threads:[~2013-05-21 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 12:43 [Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory bugs Stefan Hajnoczi
2013-05-21 12:56 ` Eric Blake
2013-05-21 15:17 ` Stefan Hajnoczi
2013-05-21 15:58 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B99B5.2040702@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lmr@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).