From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ueoxg-0003nF-7X for qemu-devel@nongnu.org; Tue, 21 May 2013 11:58:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ueoxb-0003EC-K5 for qemu-devel@nongnu.org; Tue, 21 May 2013 11:58:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ueoxb-0003E6-Ch for qemu-devel@nongnu.org; Tue, 21 May 2013 11:58:47 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4LFwkbM028838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 May 2013 11:58:46 -0400 Message-ID: <519B99B5.2040702@redhat.com> Date: Tue, 21 May 2013 09:58:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369140202-5848-1-git-send-email-stefanha@redhat.com> <519B6EE7.30207@redhat.com> <20130521151715.GA8903@stefanha-thinkpad.redhat.com> In-Reply-To: <20130521151715.GA8903@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2TOLNIAWQMPWBMQQIHBLS" Subject: Re: [Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Lucas Meneghel Rodrigues , qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TOLNIAWQMPWBMQQIHBLS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/21/2013 09:17 AM, Stefan Hajnoczi wrote: >>> + MALLOC_PERTURB_=3D${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \ >> >> This is a Makefile; don't you need to use $$ instead of $ (three insta= nces)? >> >=20 > Silly me. I did test it but it silently "worked". Yep, quite a fluke. GNU Make expands it to: MALLOC_PERTURB_=3D which meant you were setting it to the empty variable; and thus had no randomness but no syntax error to tell you your mistake. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2TOLNIAWQMPWBMQQIHBLS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRm5m1AAoJEKeha0olJ0Nq8gwH/00QVAOHLUiD/Ndy8JI/MsBt lemww9jUd5HlSefSAGDsKGW6SKOcWyrCAOIO7xhQMVEFxWeRqu7sY2lRu7ETsKJ2 BovdOoDRDrFYkf2/DPvmoYv8I4rqsewgvewkix7iTgY47hTim3sA3Rub+fWf19jF STyNo8Qhd/GvrvVP4gu1tgPhQCu7DxJIE2ajQnASMY7L5UcWSNB5wyto5q1eh1BR erCdzrMwWvUx+p69UeE97p0cY1a+k38/oSCdrF7hkHlh+HRwWo3sdV4sTUvfBkct rEqKs7D4RNBAn6qxxVm8nfLQM/+yo2wJbmgWiMQIYHA2PbYROF0ZnGAwHSQQZVE= =Jry8 -----END PGP SIGNATURE----- ------enig2TOLNIAWQMPWBMQQIHBLS--