From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uf4eP-0002Ds-Jq
	for qemu-devel@nongnu.org; Wed, 22 May 2013 04:44:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uf4eK-0003fq-BW
	for qemu-devel@nongnu.org; Wed, 22 May 2013 04:44:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55455)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uf4eK-0003ff-3A
	for qemu-devel@nongnu.org; Wed, 22 May 2013 04:43:56 -0400
Message-ID: <519C8541.6060605@redhat.com>
Date: Wed, 22 May 2013 10:43:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20130521214645.GA8863@redhat.com>
	<CAFEAcA9QfHgM8KaBFOmHvDPur=8M4YPLrnBvJsZGWG6NodaQoA@mail.gmail.com>
	<20130521220917.GA803@redhat.com>
	<87obc34fy3.fsf@blackfin.pond.sub.org>
	<20130522083732.GD7993@redhat.com>
	<CAFEAcA8+DPMrC0aLg4jEhGPie1+vM39E6K-EcTMo5j7j72EZSQ@mail.gmail.com>
In-Reply-To: <CAFEAcA8+DPMrC0aLg4jEhGPie1+vM39E6K-EcTMo5j7j72EZSQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Blue Swirl <blauwirbel@gmail.com>

Il 22/05/2013 10:38, Peter Maydell ha scritto:
> On 22 May 2013 09:37, Michael S. Tsirkin <mst@redhat.com> wrote:
>> It's my fault for running -rc kernels all the time I guess, I get
>> crashes kind of often, and losing more time on make clean
>> on top of reboot annoys me.
>> But we actually could make it robust, even against OS crash. Output to a
>> temporary file then rename.  This hack won't be needed then.
> 
> I think that would be better implemented in the compiler/linker :-)
> Alternatively, stop doing compiles on horribly unstable kernels.

Any filesystem with delayed writes can do this if you have a power loss.

But I agree that this patch doesn't solve the problem.  For example, if
you get stale files in the ccache directory even zapping the build
directory won't do.

Paolo